Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Imported token list not shown in the settings #11288

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Mar 4, 2025

To reproduce:

Import a list from manage tokens
List is not shown after imported in the list


PR-Codex overview

This PR focuses on refining the logic for managing lists based on the active chain ID, enhancing the filtering of lists and updating the dependencies in hooks to improve performance and clarity.

Detailed summary

  • Removed useActiveListUrlsByChainId from UpdaterByChainId dependencies.
  • Simplified list filtering logic in ManageLists by removing unnecessary chain ID checks.
  • Updated the useActiveListUrlsByChainId function to filter based on the chain ID of tokens.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Mar 4, 2025

⚠️ No Changeset found

Latest commit: 2ca2f57

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 6:20pm
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Mar 4, 2025 6:20pm
blog ⬜️ Ignored (Inspect) Visit Preview Mar 4, 2025 6:20pm
bridge ⬜️ Ignored (Inspect) Visit Preview Mar 4, 2025 6:20pm
games ⬜️ Ignored (Inspect) Visit Preview Mar 4, 2025 6:20pm
gamification ⬜️ Ignored (Inspect) Visit Preview Mar 4, 2025 6:20pm
uikit ⬜️ Ignored (Inspect) Visit Preview Mar 4, 2025 6:20pm
ton ⬜️ Skipped (Inspect) Mar 4, 2025 6:20pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant