-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced deprecated app.session_cookie_name with app.config["SESSION_COOKIE_NAME"]. #148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks adequately changed all occurrences of session_cookie_name
to the new approach in Flask 2.3+, thus shall be able to fix #150.
Before release, the setup.py file shall also be changed to declare "flask>=2.2".
@fengsp , do you plan to merge it in and cut a release soon?
If you would assign me the Write
permission to this repo, I will happily help the merge and release. FYI, currently, one of my projects uses flask-session
as a dependency, so I have an interest here to improve flask-session
, too.
@rayluo It seems this breaks for anyone who is using Flask < 2.3 ? |
I do not think this is an issue. When we have:
People running Flask<2.3 can still use Flask-Session==0.4.x nicely. |
Flask-Session 0.5.0 is now available. |
No description provided.