Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced deprecated app.session_cookie_name with app.config["SESSION_COOKIE_NAME"]. #148

Merged
merged 4 commits into from
May 9, 2023

Conversation

imacat
Copy link
Contributor

@imacat imacat commented Jan 2, 2023

No description provided.

Copy link
Contributor

@rayluo rayluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks adequately changed all occurrences of session_cookie_name to the new approach in Flask 2.3+, thus shall be able to fix #150.

Before release, the setup.py file shall also be changed to declare "flask>=2.2".

@fengsp , do you plan to merge it in and cut a release soon?
If you would assign me the Write permission to this repo, I will happily help the merge and release. FYI, currently, one of my projects uses flask-session as a dependency, so I have an interest here to improve flask-session, too.

@fengsp
Copy link
Contributor

fengsp commented May 5, 2023

@rayluo It seems this breaks for anyone who is using Flask < 2.3 ?

@rayluo
Copy link
Contributor

rayluo commented May 5, 2023

Welcome back, @fengsp !

@rayluo It seems this breaks for anyone who is using Flask < 2.3 ?

Not necessarily. Flask-session itself uses semantic versioning. We can have flask-session 0.4.x continue working with Flask < 2.3, and have flask-session 0.5+ using Flask >= 2.2.

@imacat
Copy link
Contributor Author

imacat commented May 5, 2023

@rayluo It seems this breaks for anyone who is using Flask < 2.3 ?

I do not think this is an issue. When we have:

  • Flask-Session 0.4.x: install_requires: Flask >=0.8, <2.3
  • Flask-Session 0.5.0: install_requires: Flask >=2.2

People running Flask<2.3 can still use Flask-Session==0.4.x nicely.

@rayluo rayluo merged commit 11d02f6 into pallets-eco:master May 9, 2023
@davidism davidism added this to the 0.5.0 milestone May 11, 2023
@davidism
Copy link
Member

Flask-Session 0.5.0 is now available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants