Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flask version should be 2.2.4 or less #102

Closed
wants to merge 1 commit into from

Conversation

konabuta
Copy link

session_cookie_name is deprecated in Flask version 3.x

session_cookie_name is deprecated in Flask version 3.x
@rayluo
Copy link
Contributor

rayluo commented Apr 26, 2023

in Flask version 3.x

Did you mean to say "2.3+"?

Also, this repo does not use that session_cookie_name. What was the issue? (Guess I can also try that out to find out...)

Regardless, pinning an upper bound is just a bandage. Ideally, we shall find a way to make it work with latest version of Flask, if it hasn't already.

@rayluo rayluo added the question Further information is requested label Apr 26, 2023
@ehuff700
Copy link

Had this same issue, didn't look into it too much but downgrading to Flask 2.2.4 worked for me.

@konabuta
Copy link
Author

@rayluo Oh, sorry. I mean Flask version 2.3+. flask_session library depends on session_cookie_name which is deprecated in Flask 2.3+. See pallets-eco/flask-session#150.

I think we should find alternative to flask_session library to use the lastest version of Flask.

@rayluo
Copy link
Contributor

rayluo commented Apr 27, 2023

Thanks for sharing the context, @konabuta . This should ideally be fixed in upstream. I have just pinged the author there. Let's give it a day or two, before we consider plan B.

@rayluo
Copy link
Contributor

rayluo commented Apr 30, 2023

You may try again by using the same web app, but re-run pip install -U -r requirements.txt. It should work this time. Please add a thumb-up reaction if your test also passes.

@rayluo rayluo added Answered and removed question Further information is requested labels Apr 30, 2023
@rayluo rayluo closed this Apr 30, 2023
@rayluo rayluo reopened this Apr 30, 2023
Copy link
Contributor

@rayluo rayluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer necessary. Still thanks for bringing this to our attention.

@rayluo rayluo closed this Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants