Skip to content
This repository was archived by the owner on Mar 25, 2021. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/configs/latest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
// tslint:disable:object-literal-key-quotes
export const rules = {
// added in v3.x
"no-invalid-this": false,
"no-angle-bracket-type-assertion": true,

// added in v4.1
Expand Down
4 changes: 0 additions & 4 deletions src/configs/recommended.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ export const rules = {
"no-reference": true,
"no-shadowed-variable": true,
"no-string-literal": true,
"no-switch-case-fall-through": false,
"no-trailing-whitespace": true,
"no-unsafe-finally": true,
"no-unused-expression": true,
Expand Down Expand Up @@ -126,7 +125,6 @@ export const rules = {
"semicolon": {
options: ["always"],
},
"switch-default": true,
"trailing-comma": {
options: {
multiline: "always",
Expand Down Expand Up @@ -213,7 +211,6 @@ export const jsRules = {
"no-reference": true,
"no-shadowed-variable": true,
"no-string-literal": true,
"no-switch-case-fall-through": false,
"no-trailing-whitespace": true,
"no-unused-expression": true,
// disable this rule as it is very heavy performance-wise and not that useful
Expand Down Expand Up @@ -241,7 +238,6 @@ export const jsRules = {
"semicolon": {
options: ["always"],
},
"switch-default": true,
"trailing-comma": {
options: {
multiline: "always",
Expand Down
3 changes: 2 additions & 1 deletion src/rules/noInferrableTypesRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,8 @@ class NoInferrableTypesWalker extends Lint.AbstractWalker<IOptions> {
hasModifier(node.modifiers, ts.SyntaxKind.ReadonlyKeyword)) {
break;
}
/* falls through*/
this.checkDeclaration(node as ts.VariableLikeDeclaration);
break;
case ts.SyntaxKind.VariableDeclaration:
this.checkDeclaration(node as ts.VariableLikeDeclaration);
}
Expand Down
98 changes: 0 additions & 98 deletions src/rules/noInvalidThisRule.ts

This file was deleted.

118 changes: 0 additions & 118 deletions src/rules/noSwitchCaseFallThroughRule.ts

This file was deleted.

3 changes: 2 additions & 1 deletion src/rules/noUnnecessaryQualifierRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@ class Walker extends Lint.ProgramAwareRuleWalker {
this.visitNamespaceAccess(node, expression, name);
break;
}
// falls through
super.visitNode(node);
break;
default:
super.visitNode(node);
}
Expand Down
3 changes: 2 additions & 1 deletion src/rules/trailingCommaRule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,8 @@ class TrailingCommaWalker extends Lint.AbstractWalker<Options> {
if ((node as ts.NewExpression).arguments === undefined) {
break;
}
// falls through
this.checkList((node as ts.CallExpression | ts.NewExpression).arguments!, node.end);
break;
case ts.SyntaxKind.CallExpression:
this.checkList((node as ts.CallExpression | ts.NewExpression).arguments!, node.end);
break;
Expand Down
1 change: 1 addition & 0 deletions src/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"compilerOptions": {
"module": "commonjs",
"noFallthroughCasesInSwitch": true,
"noImplicitAny": true,
"noImplicitReturns": true,
"noImplicitThis": true,
Expand Down
60 changes: 0 additions & 60 deletions test/rules/no-invalid-this/enabled/test.js.lint

This file was deleted.

Loading