Skip to content
This repository was archived by the owner on Mar 25, 2021. It is now read-only.

Remove no-switch-case-fallthrough and no-invalid-this#2422

Closed
nchen63 wants to merge 2 commits intomasterfrom
remove-rules
Closed

Remove no-switch-case-fallthrough and no-invalid-this#2422
nchen63 wants to merge 2 commits intomasterfrom
remove-rules

Conversation

@nchen63
Copy link
Contributor

@nchen63 nchen63 commented Mar 28, 2017

fixes #1861

CHANGELOG.md entry:

[removed-rule] no-switch-case-fallthrough: use tsc switch --noFallthroughCasesInSwitch instead
[removed-rule] no-invalid-this: use tsc switch --noImplicitThis instead
[recommended-removed] switch-default removed from recommended rule set

@ajafff
Copy link
Contributor

ajafff commented Mar 28, 2017

I'd rather not remove those rules now. Ideally we would wait until typescript adds the ability to disable such errors: microsoft/TypeScript#11051
no-unused-variable was undeprecated for that reason, too.

Keeping those rules around doesn't add much (if any) additional maintenance burden, so I don't see a reason to rush on removing them.

In addition, typescript will eventually start using no-switch-case-fall-through in their project, see microsoft/TypeScript#14886

@adidahiya
Copy link
Contributor

fair enough, I didn't realize the TS team is using no-switch-case-fall-through. @nchen63 let's keep the rules around and just remove switch-default from tslint:recommended in this PR

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@nchen63
Copy link
Contributor Author

nchen63 commented Mar 29, 2017

done in #2424

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A few rules are mostly redundant in newer TypeScripts with specific compiler options

3 participants