Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Fix type parameter of applyWithFunction #2396

Merged
merged 1 commit into from
Mar 31, 2017
Merged

Fix type parameter of applyWithFunction #2396

merged 1 commit into from
Mar 31, 2017

Conversation

ajafff
Copy link
Contributor

@ajafff ajafff commented Mar 24, 2017

PR checklist

  • Addresses an existing issue: #0000
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Overview of change:

Type of options should not be used to infer type parameter T.
Refs: microsoft/TypeScript#14829

CHANGELOG.md entry:

[no-log]

Type of `options` should not be used to infer type parameter `T`.
Refs: microsoft/TypeScript#14829
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subtle! thanks for the fix @ajafff

@jkillian jkillian merged commit f03c1ad into palantir:master Mar 31, 2017
@nchen63
Copy link
Contributor

nchen63 commented Mar 31, 2017

master was broken because of conflict

@jkillian
Copy link
Contributor

😿 sorry, will fix!

@andy-hanson
Copy link
Contributor

andy-hanson commented Apr 2, 2017

This made e6f3626 necessary. If TypeScript sees T and U used separately, it will infer the correct type for U and {} for T. It may just need a version that provides a TypedContext.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants