Fix type parameter of applyWithFunction (#2396)

Type of `options` should not be used to infer type parameter `T`. Refs: microsoft/TypeScript#14829
palantir · Mar 31, 2017 · f03c1ad · f03c1ad
1 parent b55a9f9
commit f03c1ad
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/src/language/rule/abstractRule.ts b/src/language/rule/abstractRule.ts
@@ -49,8 +49,16 @@ export abstract class AbstractRule implements IRule {
     }
 
     protected applyWithFunction(sourceFile: ts.SourceFile, walkFn: (ctx: WalkContext<void>) => void): RuleFailure[];
-    protected applyWithFunction<T>(sourceFile: ts.SourceFile, walkFn: (ctx: WalkContext<T>) => void, options: T): RuleFailure[];
-    protected applyWithFunction<T>(sourceFile: ts.SourceFile, walkFn: (ctx: WalkContext<T | void>) => void, options?: T): RuleFailure[] {
+    protected applyWithFunction<T, U extends T>(
+        sourceFile: ts.SourceFile,
+        walkFn: (ctx: WalkContext<T>) => void,
+        options: U,
+    ): RuleFailure[];
+    protected applyWithFunction<T, U extends T>(
+        sourceFile: ts.SourceFile,
+        walkFn: (ctx: WalkContext<T | void>) => void,
+        options?: U,
+    ): RuleFailure[] {
         const ctx = new WalkContext(sourceFile, this.ruleName, options);
         walkFn(ctx);
         return this.filterFailures(ctx.failures);