Skip to content

Treat classnames with only skipped tests as having taken 0 time #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dansanduleac merged 2 commits into from
Mar 25, 2018
Merged

Treat classnames with only skipped tests as having taken 0 time #336

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ed707e
Don't forget classnames with no tests
dansanduleac Mar 24, 2018
999b073
Merge remote-tracking branch 'origin/master' into ds/dont-forget-clas…
dansanduleac Mar 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions project/CirclePlugin.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@ object CirclePlugin extends AutoPlugin {

case class TestKey(source: String, classname: String)

// Through this magical command we established that the average class run_time is 7.737
// Through this magical command we established that the average class run_time is 8.841
// jq <~/results.json '.tests | map(select(.result != "skipped")) | group_by(.classname) | map(map(.run_time) | add) | (add / length)'
private[this] val AVERAGE_TEST_CLASS_RUN_TIME = 7.737d
private[this] val AVERAGE_TEST_CLASS_RUN_TIME = 8.841d

override def globalSettings: Seq[Def.Setting[_]] = List(
circleTestsByProject := {
Expand Down Expand Up @@ -109,9 +109,9 @@ object CirclePlugin extends AutoPlugin {
.map(_.asScala)
.getOrElse(Iterator())
.toStream
.filter(_.result != "skipped") // don't count timings of tests that didn't run
.groupBy(result => TestKey(result.source, result.classname))
.mapValues(_.foldLeft(0.0d)(_ + _.run_time))
// don't count timings on skipped tests, but remember we've seen the classname
.mapValues(_.filter(_.result != "skipped").foldLeft(0.0d)(_ + _.run_time))
} catch {
case e: Exception =>
log.warn(f"Couldn't read test results file: $testResultsFile")
Expand Down