Treat classnames with only skipped tests as having taken 0 time#336
Merged
dansanduleac merged 2 commits intomasterfrom Mar 25, 2018
Merged
Treat classnames with only skipped tests as having taken 0 time#336dansanduleac merged 2 commits intomasterfrom
dansanduleac merged 2 commits intomasterfrom
Conversation
dansanduleac
changed the title
yifeih
pushed a commit
that referenced
this pull request
Jun 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the test timings file, if a classname has no tests that ran (all were skipped), treat this classname as having taken 0 time rather than as if there was no timing information about it.
Also update the average test run time after running the query on a more complete test results file.