Skip to content

Hadoop 2.9.0-palantir.2#283

Merged
ash211 merged 7 commits intomasterfrom
hadoop-2.9.0
Nov 17, 2017
Merged

Hadoop 2.9.0-palantir.2#283
ash211 merged 7 commits intomasterfrom
hadoop-2.9.0

Conversation

@sjrand
Copy link

@sjrand sjrand commented Nov 12, 2017

Just for testing right now. Once that's done, will cut 2.9.0-palantir.1 and update the PR.

@sjrand
Copy link
Author

sjrand commented Nov 13, 2017

This looks good. I built a Spark dist based on this branch and did some reads and writes against:

  • HDFS
  • s3a
  • FFS backed by s3a

All operations succeeded. Will make 2.9.0-palantir.1 now.

@sjrand
Copy link
Author

sjrand commented Nov 14, 2017

Not sure what's up with the test failure. The value of localHttpJar.head does start with file: when I look at in in the debugger. Can't actually get the tests running/passing locally for silly reasons, so not sure if the test would pass locally or not.

EDIT: Turns out I was using Hadoop 2.6.5 locally when I wrote this.

@sjrand
Copy link
Author

sjrand commented Nov 16, 2017

Okay, fine, the test failure is legit. Somehow the behavior of FileSystem.getFileSystemClass changed b/w 2.8.2 and 2.9.0 s.t. this line returns true in the former and false in the latter: https://github.com/palantir/spark/blob/master/core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala#L407.

@sjrand
Copy link
Author

sjrand commented Nov 16, 2017

And to make things even harder to figure out, the culprit isn't even a code change

srand06-mac:hadoop srand$ git branch
* branch-2.8.2
  branch-2.9.0
srand06-mac:hadoop srand$ grep 'org\.apache' ./hadoop-common-project/hadoop-common/src/main/resources/META-INF/services/org.apache.hadoop.fs.FileSystem
org.apache.hadoop.fs.LocalFileSystem
org.apache.hadoop.fs.viewfs.ViewFileSystem
org.apache.hadoop.fs.ftp.FTPFileSystem
org.apache.hadoop.fs.HarFileSystem
srand06-mac:hadoop srand$ git co branch-2.9.0
Switched to branch 'branch-2.9.0'
Your branch is up-to-date with 'origin/branch-2.9.0'.
srand06-mac:hadoop srand$ grep 'org\.apache' ./hadoop-common-project/hadoop-common/src/main/resources/META-INF/services/org.apache.hadoop.fs.FileSystem
org.apache.hadoop.fs.LocalFileSystem
org.apache.hadoop.fs.viewfs.ViewFileSystem
org.apache.hadoop.fs.ftp.FTPFileSystem
org.apache.hadoop.fs.HarFileSystem
org.apache.hadoop.fs.http.HttpFileSystem
org.apache.hadoop.fs.http.HttpsFileSystem

That line doesn't throw anymore just because org.apache.hadoop.fs.http.HttpFileSystem got added to the provider configuration file.

@sjrand sjrand changed the title [WIP] Hadoop 2.9.0 Hadoop 2.9.0 Nov 16, 2017
@sjrand sjrand requested review from ash211 and onursatici November 16, 2017 07:18
@ash211 ash211 changed the title Hadoop 2.9.0 Hadoop 2.9.0-palantir.2 Nov 17, 2017
@ash211 ash211 merged commit 65956b7 into master Nov 17, 2017
@ash211 ash211 deleted the hadoop-2.9.0 branch November 17, 2017 02:34
ash211 pushed a commit that referenced this pull request Dec 5, 2017
* Revert "Bump Hadoop to 2.9.0-palantir.3 (#288)"

This reverts commit bb010b8.

* Revert "Hadoop 2.9.0-palantir.2 (#283)"

This reverts commit 65956b7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants