Skip to content

Downgrade hadoop to 2.8.2-palantir.2#289

Merged
ash211 merged 2 commits intopalantir:masterfrom
rahij:rr/downgrade-hadoop
Dec 5, 2017
Merged

Downgrade hadoop to 2.8.2-palantir.2#289
ash211 merged 2 commits intopalantir:masterfrom
rahij:rr/downgrade-hadoop

Conversation

@rahij
Copy link

@rahij rahij commented Dec 5, 2017

@ash211 @sjrand

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

How was this patch tested?

Faith

Please review http://spark.apache.org/contributing.html before opening a pull request.

Copy link

@sjrand sjrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad, but seems like the right move for now

@ash211 ash211 merged commit 0d26e34 into palantir:master Dec 5, 2017
@ash211
Copy link

ash211 commented Dec 5, 2017

@rahij can you please send PRs from this repo instead of a fork in the future? That way circle will run integration tests.

@rahij
Copy link
Author

rahij commented Dec 5, 2017

I somehow couldn't push directly, can you give me access? (Also you can enable running integration tests on forks as well on circle).

@ash211
Copy link

ash211 commented Dec 5, 2017

you're enabled

Copy link

@robert3005 robert3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer to not merge it and fixed said library

@ash211 ash211 mentioned this pull request Dec 5, 2017
@ash211
Copy link

ash211 commented Dec 5, 2017

Yep working on fixing that library independently, but the upside of merging now is that we have a version to land on for correctness issue at #286

@rahij rahij deleted the rr/downgrade-hadoop branch December 26, 2017 23:19
sjrand added a commit that referenced this pull request Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants