Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove noisy output #458

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Remove noisy output #458

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
69b0e7b
Remove noisy output
pkoenig10 Nov 5, 2024
404e436
Add generated changelog entries
svc-changelog Nov 5, 2024
569244b
Update gradle-jdks-functions.sh
CRogers Nov 5, 2024
af476ed
Remove noisy log line from actual file
CRogers Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion gradle/gradle-jdks-functions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ install_and_setup_jdks() {
elif [ ! -f "$jdk_installation_directory/bin/java" ]; then
echo "Java executable not found in $jdk_installation_directory/bin/java, re-installing the JDK...."
else
echo "JDK installation $jdk_installation_directory was already configured"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm, this is noisy, it was added in #452. We should probably have some test that we don't print anything when the JDK is already installed (to be added later).

continue
fi
# Download and extract the distribution into a temporary directory
Expand Down