Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove noisy output #458

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Remove noisy output #458

merged 4 commits into from
Nov 5, 2024

Conversation

pkoenig10
Copy link
Member

This output is emitted on every Gradle build for every JDK.

JDK installation /Users/pkoenig/.gradle/gradle-jdks/amazon-corretto-11.0.25.9.1 was already configured
JDK installation /Users/pkoenig/.gradle/gradle-jdks/amazon-corretto-17.0.13.11.1 was already configured
JDK installation /Users/pkoenig/.gradle/gradle-jdks/amazon-corretto-21.0.5.11.1 was already configured

@@ -127,7 +127,6 @@ install_and_setup_jdks() {
elif [ ! -f "$jdk_installation_directory/bin/java" ]; then
echo "Java executable not found in $jdk_installation_directory/bin/java, re-installing the JDK...."
else
echo "JDK installation $jdk_installation_directory was already configured"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm, this is noisy, it was added in #452. We should probably have some test that we don't print anything when the JDK is already installed (to be added later).

@CRogers
Copy link
Contributor

CRogers commented Nov 5, 2024

👍

@changelog-app
Copy link

changelog-app bot commented Nov 5, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Remove noisy output that "JDK installation X was already configured".

Check the box to generate changelog(s)

  • Generate changelog entry

@CRogers
Copy link
Contributor

CRogers commented Nov 5, 2024

👍

@felixdesouza
Copy link

👍

@bulldozer-bot bulldozer-bot bot merged commit e150f73 into develop Nov 5, 2024
6 checks passed
@bulldozer-bot bulldozer-bot bot deleted the pkoenig10-patch-1 branch November 5, 2024 16:34
@autorelease3
Copy link

autorelease3 bot commented Nov 5, 2024

Released 0.55.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants