Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump react-popper dependency to fix rare infinite loop #3884

Closed
wants to merge 3 commits into from

Conversation

mfedderly
Copy link
Contributor

Fixes #2029

Changes proposed in this pull request:

Incorporate floating-ui/react-popper#320

yarn.lock Outdated
@@ -2808,6 +2808,18 @@ deep-equal@^1.0.1:
resolved "https://registry.yarnpkg.com/deep-equal/-/deep-equal-1.0.1.tgz#f5d260292b660e084eff4cdbc9f08ad3247448b5"
integrity sha1-9dJgKStmDghO/0zbyfCK0yR0SLU=

deep-equal@^1.1.1:
version "1.1.1"
resolved "https://artifactory.palantir.build/artifactory/api/npm/all-npm/deep-equal/-/deep-equal-1.1.1.tgz#b5c98c942ceffaf7cb051e24e1434a25a2e6076a"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

artifact url should be public https://registry.yarnpkg.com

yarn.lock Outdated
@@ -5077,6 +5089,11 @@ is-alphanumerical@^1.0.0:
is-alphabetical "^1.0.0"
is-decimal "^1.0.0"

is-arguments@^1.0.4:
version "1.0.4"
resolved "https://artifactory.palantir.build/artifactory/api/npm/all-npm/is-arguments/-/is-arguments-1.0.4.tgz#3faf966c7cba0ff437fb31f6250082fcf0448cf3"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

artifact url should be public https://registry.yarnpkg.com

yarn.lock Outdated
integrity sha512-KkpaLARMhsTsgp0d2NA/R94F/eDLbhXERdIq3LvX2biCAXcDvHYoOqHfWCHf1+OLj+HKBotLG3KqaOOf+C1C+A==
create-react-context@^0.3.0:
version "0.3.0"
resolved "https://artifactory.palantir.build/artifactory/api/npm/all-npm/create-react-context/-/create-react-context-0.3.0.tgz#546dede9dc422def0d3fc2fe03afe0bc0f4f7d8c"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

artifact url should be public https://registry.yarnpkg.com

yarn.lock Outdated
integrity sha512-ynMZBPkXONPc5K4P5yFWgZx5JGAUIP3pGGLNs58cfAPgK67olx7fmLp+AdpZ0+GoQ+ieFDa/z4cdV6u7sioH6w==
react-popper@^1.3.7:
version "1.3.7"
resolved "https://artifactory.palantir.build/artifactory/api/npm/all-npm/react-popper/-/react-popper-1.3.7.tgz#f6a3471362ef1f0d10a4963673789de1baca2324"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

artifact url should be public https://registry.yarnpkg.com

yarn.lock Outdated
@@ -8705,6 +8723,13 @@ regex-not@^1.0.0, regex-not@^1.0.2:
extend-shallow "^3.0.2"
safe-regex "^1.1.0"

regexp.prototype.flags@^1.2.0:
version "1.2.0"
resolved "https://artifactory.palantir.build/artifactory/api/npm/all-npm/regexp.prototype.flags/-/regexp.prototype.flags-1.2.0.tgz#6b30724e306a27833eeb171b66ac8890ba37e41c"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

artifact url should be public https://registry.yarnpkg.com

@mfedderly mfedderly force-pushed the mf/bump-react-popper branch from 5217364 to eb3c6bb Compare December 9, 2019 17:03
Copy link

@schlosna schlosna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defer to @palantir/blueprint for merge, but LGTM. Thanks for finding, fixing upstream, and bumping 😄

@mfedderly
Copy link
Contributor Author

Fixed by #3885

@mfedderly mfedderly closed this Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip2/Popover2 cause infinite loop when Chrome is zoomed out to or past 75%
2 participants