Tooltip2/Popover2 cause infinite loop when Chrome is zoomed out to or past 75%

[tyscorp]

Bug report

• Package version(s): v1.x and v2.x
• Browser and OS versions: Chrome 63, MacOS X 10.13.

Steps to reproduce

1. Zoom Chrome out to at least 75%
2. Open a Tooltip2 or Popover2

This is reproducible on the blueprint v2 docs with the "Hover and click me" button when you click it.

A quick "fix" is to disable zooming on Chrome by setting document.body.style.zoom to 1 / window.devicePixelRatio initially and every resize.

Actual behavior

Chrome freezes at 100% CPU usage with no console error.

This error is very inconsistent and appears to depend on the size of the popover/tooltip. I have a feeling this is related to Popper.js. Perhaps this issue?

[giladgray]

oh yeah total repro, straight to crash city :(
very likely this is related to that Popper.js issue floating-ui/floating-ui#496, but i'll leave this open to redirect.

[atomiks]

FWIW, this doesn't seem to happen with my lib which uses Popper.js.

https://atomiks.github.io/tippyjs/

[tnrich]

@giladgray I just spent a long time trying to track down this bug which occurs for certain tooltips but not others. Very confusing.

It seems like it is probably a popper.js issue, but is there something blueprint can do in the meantime to make it so users don't hit this? Maybe temporarily apply the quick fix above:

A quick "fix" is to disable zooming on Chrome by setting document.body.style.zoom to 1 / window.devicePixelRatio initially and every resize.

[giladgray]

@tnrich awesome, thanks for tracking that down! a fix like you suggest certainly does not belong in a library like Blueprint; it belongs in your app initialization code. we can't ban zooming across the board!

[tnrich]

@giladgray I wasn't suggesting that this be a permanent solution, but I do think having it in there until popperjs gets fixed would be a net benefit to blueprint users. Otherwise you'll have some very confusing and buggy behavior.

Or help fix popper :)

Your call of course still though.

[tyscorp]

@tnrich The fix I posted above doesn't work on Retina displays on Mac.

[giladgray]

@tnrich that's the kind of fix that belongs in your app initialization code, not as a side effect from a library import.

[tnrich]

This seems to have stopped happening for me. Anyone else not getting this anymore?

[giladgray]

I'm not seeing it either!

[llorca]

fixed by popper? should we close?

[marvinsum]

@giladgray I think we're still seeing this issue on Chrome 70, Mac OS High Sierra.

[adidahiya]

Going to close this issue, please open a new one with more details about the exact Popover/Tooltip API usage (and ideally a codesandbox repro) if you still see this.

[schlosna]

Possibly related to floating-ui/react-popper#320

[jalessio]

@schlosna Relating that in our case the fix proposed in floating-ui/react-popper#320 addressed the issue described here for our app which utilizes Blueprint.

[schlosna]

@adidahiya we should probably reopen this to track @mfedderly ’s upstream popper fix to merge & release.

[adidahiya]

fixed by #3885