[DateInput] No longer defaults to Today with time precision enabled #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, fix syntax in testPreview: documentation |
llorca
changed the title
llorca
approved these changes
Jul 14, 2017
giladgray
pushed a commit
that referenced
this pull request
Jul 19, 2017
…1349) * Today's date stays deselected on open * Add test for value=null * Oops, fix syntax in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1246 (again)
Checklist
Changes proposed in this pull request:
DateInputwith time precision enabled no longer defaults to Today when popover re-opens with controlledvalue === nullReviewers should focus on:
Fixing the time fields (to not clear on popover re-open) would require more plumbing work, and I wasn't sure what the best UX was. @llorca? I also wanted to bias toward getting this quick fix submitted.
Screenshot