[DateInput] Today's date looks like it's selected but is in fact not

[marwahaha]

Bug report

• Package version(s): 1.20.0
• Browser and OS versions: Chrome 58.0.3029.110

Steps to reproduce

1. Go to http://blueprintjs.com/docs/#datetime/dateinput
2. Set precision to something (not None)
3. Click on input and remove date
4. Click away and click again on (empty input)

Actual behavior

5. Today's date is "selected" on the calendar

Expected behavior

5. Today's date is not "selected" on the calendar.

You can contrast this with skipping step 2, and seeing no bug.

[llorca]

Uh oh, good catch. Will look at it next week, hopefully it's a quick fix

[cmslewis]

Update: after investigating, looks like this.state.value is being updated properly on deselect, but this.state.valueString is not. On it.

[marwahaha]

Hi @cmslewis @llorca , I tried my reproduction steps on the Blueprint website and it still wasn't working. Can you re-open this?

[cmslewis]

Yep, looks like it reselects today's date when the popover is reopened. Dang.

[lintardec]

Hi @cmslewis @llorca,

I'm seeing the same issue in the DateTimePicker component

blueprintjs/datetime package : 2.0.3

when my props.value is undefined the current date is selected

<DateTimePicker
value={isUndefined(props.value) ? undefined : props.formattedStringToDate(props.value)}
onChange={(selectedDate: Date, isUserChange: boolean) =>
props.updateQueryData(props.name, props.dateToFormattedString(selectedDate))}
/>
unlike using DatePicker
<DatePicker
value={isUndefined(props.value) ? undefined : props.formattedStringToDate(props.value)}
onChange={(selectedDate: Date, isUserChange: boolean) =>
props.updateQueryData(props.name, props.dateToFormattedString(selectedDate))}
/>

should this be raised as a new bug?