remove 'invalid conan purl only channel qualifier' testcases #734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 4, 2025
Contributor
Author
|
Anything preventing this from being merged? |
shibumi
approved these changes
Dec 3, 2025
Member
|
@petergardfjall do you mind to resolve any merge conflict? I am too lazy to do it ;) Thanks ❤️ |
petergardfjall
force-pushed
the
remove-conan-channel-testcases
branch
from
b079128 to
ce49c28
Compare
Contributor
Author
Certainly. It is now rebased on |
petergardfjall
force-pushed
the
remove-conan-channel-testcases
branch
from
ce49c28 to
71de5e9
Compare
shibumi
approved these changes
Dec 5, 2025
Contributor
Author
@pombredanne: Should be fine to merge. |
shibumi
approved these changes
Dec 8, 2025
petergardfjall
force-pushed
the
remove-conan-channel-testcases
branch
from
71de5e9 to
1a99770
Compare
Signed-off-by: Peter Gardfjäll <[email protected]>
petergardfjall
force-pushed
the
remove-conan-channel-testcases
branch
from
1a99770 to
c55fab1
Compare
Contributor
Author
|
@pombredanne kind reminder :) |
mjherzog
approved these changes
Dec 12, 2025
Member
mjherzog
left a comment
mjherzog
left a comment
There was a problem hiding this comment.
Looks good. The first two test cases also seem to be duplicates.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #643 by removing testcases that don't have any apparent support in the spec.
The channel qualifier is an optional qualifier and so is the
pkg:conannamespace component.These testcases seem to suggest there being some relationship between qualifier and namespace.
A relationship that has no apparent support in the spec.