remove 'invalid conan purl only namespace' testcases #733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Gardfjäll <[email protected]>
petergardfjall
changed the title
This was referenced Nov 4, 2025
Closed
mjherzog
approved these changes
Nov 5, 2025
Member
mjherzog
left a comment
mjherzog
left a comment
There was a problem hiding this comment.
These test cases are wrong as stated - namespace is optional and therefore allowed for a conan PURL type
Contributor
|
@petergardfjall thanks for the PR! this still not fixes #731 This test needs to be removed as well, thanks! purl-spec/tests/types/conan-test.json Line 143 in 3e27e92 |
Contributor
Author
That's taken care of in a separate pr: #734 |
Contributor
Author
|
Anything preventing this from being merged? |
shibumi
approved these changes
Dec 3, 2025
Member
|
Merging with 2 reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #731.
In the current formulation of the conan spec the presence of
namespaceis optional.The testcases removed in this PR therefore make no sense.