Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix min_range #88

Merged
merged 1 commit into from
Sep 18, 2020
Merged

Bugfix min_range #88

merged 1 commit into from
Sep 18, 2020

Conversation

pablosanjose
Copy link
Owner

There was an edge case opened by #87 whereby a min_range larger than several bravais vectors would make the search algorithm for hoppings bail out too soon and link nothing. This resolves the issue by not allowing the search to stop until min_range is surpassed

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2020

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.16%. Comparing base (2844154) to head (c86ff26).
Report is 1196 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   63.06%   63.16%   +0.09%     
==========================================
  Files          16       16              
  Lines        2694     2701       +7     
==========================================
+ Hits         1699     1706       +7     
  Misses        995      995              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pablosanjose pablosanjose merged commit 315ca79 into master Sep 18, 2020
@pablosanjose pablosanjose deleted the fix_rmin branch September 19, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants