Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #86
Nothing much to discuss here. Just a note on implementation. Instead of doing a tree search with NearestNeighbors strictly in the (rmin, rmax) range, we still do a target candidate search with rmax, and then rely on the selector check to exclude those with norm below rmin. Also, eps(T) padding of range is done to ensure that
range = (1,1)
selects anything at distance 1, regardless of floating point errors.