Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow range = (rmin, rmax) #87

Merged
merged 2 commits into from
Sep 16, 2020
Merged

Allow range = (rmin, rmax) #87

merged 2 commits into from
Sep 16, 2020

Conversation

pablosanjose
Copy link
Owner

@pablosanjose pablosanjose commented Sep 16, 2020

Closes #86

Nothing much to discuss here. Just a note on implementation. Instead of doing a tree search with NearestNeighbors strictly in the (rmin, rmax) range, we still do a target candidate search with rmax, and then rely on the selector check to exclude those with norm below rmin. Also, eps(T) padding of range is done to ensure that range = (1,1) selects anything at distance 1, regardless of floating point errors.

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2020

Codecov Report

Merging #87 into master will increase coverage by 0.32%.
The diff coverage is 88.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   62.74%   63.06%   +0.32%     
==========================================
  Files          16       16              
  Lines        2668     2694      +26     
==========================================
+ Hits         1674     1699      +25     
- Misses        994      995       +1     
Impacted Files Coverage Δ
src/Quantica.jl 100.00% <ø> (ø)
src/plot_makie.jl 0.00% <0.00%> (ø)
src/plot_vegalite.jl 0.00% <0.00%> (ø)
src/presets.jl 32.07% <ø> (ø)
src/lattice.jl 68.02% <87.50%> (+0.63%) ⬆️
src/model.jl 75.88% <89.28%> (+6.06%) ⬆️
src/hamiltonian.jl 75.07% <90.90%> (-0.56%) ⬇️
src/parametric.jl 84.04% <100.00%> (ø)
src/tools.jl 65.47% <100.00%> (-3.14%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd55751...88fd764. Read the comment docs.

@pablosanjose pablosanjose merged commit 2844154 into master Sep 16, 2020
This was referenced Sep 18, 2020
@pablosanjose pablosanjose deleted the rmin branch September 19, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

range = (min, max)
2 participants