Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug #23: Tuple unpacking incompatible with Python 3.4 and less #40

Merged
merged 1 commit into from
Jul 18, 2018

Conversation

hx2A
Copy link
Contributor

@hx2A hx2A commented Mar 22, 2018

Simple fix for this bug so the package is backwards compatible.

@abhikpal
Copy link
Member

abhikpal commented Jun 4, 2018

Yep, this doe s fix the issue :) I've merged this to develop

@jeremydouglass
Copy link
Contributor

More compatibility in the code base is better... but isn't it the case that p5py will still require minimum 3.5 #41 anyway? At least, as long as it uses things like the @ matrix multiplication operator -- as for example in:

https://github.com/p5py/p5/blob/master/p5/pmath/vector.py#L345

@hx2A
Copy link
Contributor Author

hx2A commented Jun 4, 2018

@jeremydouglass that is a fair point but I'd argue that the new version is also more readable. Also, if supporting previous versions of Python is important it would be easy to change the few places that use the @ operator with the numpy matrix multiplication function.

@jeremydouglass
Copy link
Contributor

@hx2A -- good points. To be clear, I'm not against this change in #40 -- I agree that more previous Python 3.x version compatibility is better.

@hx2A
Copy link
Contributor Author

hx2A commented Jun 5, 2018

@jeremydouglass agreed! I like the new @ operator also but perhaps if its use in p5py limits Python compatibility then that should be modified also? Replacing it with numpy's matrix multiplication function should suffice.

This project is part of the Google Summer of Code. Are one of you the person working on this?

@abhikpal
Copy link
Member

abhikpal commented Jun 5, 2018

This project is part of the Google Summer of Code. Are one of you the person working on this?

I'm working on this actually. PR #22 already solves the np.dot / @ issue and it has been merged to the develop branch. These will be merged to master soon.

@hx2A
Copy link
Contributor Author

hx2A commented Jun 5, 2018

@abhikpal awesome! I'm eager to work with the final result at the end of the summer.

@abhikpal
Copy link
Member

abhikpal commented Jun 5, 2018

@hx2A, thanks! You're also welcome (and encouraged) to test things out and give us feedback over the summer as well :)

@abhikpal abhikpal added this to the Pre-VisPy release milestone Jun 5, 2018
@abhikpal abhikpal self-assigned this Jun 5, 2018
@abhikpal abhikpal modified the milestones: Pre-VisPy release, Port backend to VisPy Jun 12, 2018
@abhikpal abhikpal merged commit ac19dae into p5py:master Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants