Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced @ with np.dot() #22

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Replaced @ with np.dot() #22

merged 1 commit into from
Jul 18, 2018

Conversation

arihantparsoya
Copy link
Member

@arihantparsoya arihantparsoya commented Dec 24, 2017

Fixes #18 .

Replaced all @ operator with np.dot since @ operator was introduced from python3.5.
There are still some issues while running the code:

    from p5 import *
  File "/Users/arihantparsoya/Documents/p5/p5/__init__.py", line 19, in <module>
    from .sketch import *
  File "/Users/arihantparsoya/Documents/p5/p5/sketch/__init__.py", line 19, in <module>
    from .base import *
  File "/Users/arihantparsoya/Documents/p5/p5/sketch/base.py", line 29, in <module>
    from ..opengl import renderer
  File "/Users/arihantparsoya/Documents/p5/p5/opengl/__init__.py", line 19, in <module>
    from .renderer import *
  File "/Users/arihantparsoya/Documents/p5/p5/opengl/renderer.py", line 33, in <module>
    from ..pmath import matrix
  File "/Users/arihantparsoya/Documents/p5/p5/pmath/__init__.py", line 22, in <module>
    from .curves import *
  File "/Users/arihantparsoya/Documents/p5/p5/pmath/curves.py", line 46
    ret_value = func(*new_args, parameter, **kwargs)
                                       ^
SyntaxError: only named arguments may follow *expression

Fixes p5py#18 .
Replaced all @ operator with np.dot since @ operator was introduced from python3.5
@abhikpal
Copy link
Member

Amazing! This looks very good. I don't have access to my own machine until the 2018-01-03, I'll merge this to develop after the 3rd.

@abhikpal abhikpal added this to the Pre-VisPy release milestone Jun 5, 2018
@abhikpal abhikpal self-assigned this Jun 5, 2018
@abhikpal abhikpal modified the milestones: Pre-VisPy release, Port backend to VisPy Jun 12, 2018
@abhikpal abhikpal merged commit d70a6c8 into p5py:master Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants