Improve diagnostics for BaseListExpression, StructExpression, and AssignmentStatement
#4353
Conversation
| y = 32w1; // Error: no implicit cast to enum | ||
| ^ | ||
| enumCast.p4(3) | ||
| enum bit<32> X { | ||
| ^ | ||
| enumCast.p4(33): [--Werror=type-error] error: AssignmentStatement: values of type 'E2' cannot be implicitly cast to type 'E1' | ||
| enumCast.p4(33): [--Werror=type-error] error: a = b: values of type 'E2' cannot be implicitly cast to type 'E1' |
There was a problem hiding this comment.
It looks like the assignment statement here is missing quotes, which makes it harder to read.
There was a problem hiding this comment.
Do you mean like "a = b"?
There was a problem hiding this comment.
Are you requesting to add quotes only to the error messages validated in the tests that this PR affects, or to all error messages that might possibly print an IR::AssignmentStatement? The latter would take a lot of time so if that's the case then I'll probably just leave the AssignmentStatement::toString() method as it is.
There was a problem hiding this comment.
It is probably prudent to only add quotes to the error messages that are changed in this PR for now. Changing all error messages might be too much too ask for.
I'm going to open separate PRs for each of the IR classes to help isolate the cause. |
supersedes #3232