Improve diagnostic messages for AssignmentStatement, Operation_Binary, ListExpression, and StructExpression
#3232
Conversation
| @@ -1,6 +1,6 @@ | |||
| parser_pragma2.p4(18): [--Wwarn=parser-transition] warning: SelectCase: unreachable | |||
| 0xAB00 : Cowles; | |||
| ^^^^^^ | |||
| parser_pragma2.p4(16): [--Wwarn=parser-transition] warning: 'ListExpression': transition does not depend on select argument | |||
| parser_pragma2.p4(16): [--Wwarn=parser-transition] warning: '{ tmp }': transition does not depend on select argument | |||
There was a problem hiding this comment.
This is one problem with this improvement: this error message no longer makes sense.
There was a problem hiding this comment.
I noticed that too and I am not sure of a good way to fix this. Is this problem unique to ListExpression components, or is it a problem when printing compiler-generated Expressions in other places, too?
There was a problem hiding this comment.
No, it happens in other places as well.
| @@ -1,3 +1,3 @@ | |||
| issue2317.p4(16): [--Werror=type-error] error: ==: cannot be applied to action results | |||
| issue2317.p4(16): [--Werror=type-error] error: f == f: cannot be applied to action results | |||
There was a problem hiding this comment.
this one is also confusing
There was a problem hiding this comment.
This one can be fixed by enhancing MethodCallExpression's toString() method. This change would affect ~110 tests so I opted to leave that for a separate PR, but I can make that change here if you prefer.
This is not unique to printing MethodCallExpressions used in binary operations, though. The MethodCallExpression will be printed as f in other places too.
|
superseded by #4353 |
No description provided.