Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

match_kind is a base type #1020

Merged
merged 1 commit into from
Feb 28, 2022
Merged

match_kind is a base type #1020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions p4-16/spec/P4-16-spec.mdk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1828,6 +1828,7 @@ P4 supports the following built-in base types:
baseType
: BOOL
| ERROR
| MATCH_KIND
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit-pick, but should we go ahead and make the relative order of the other alternatives BIT, INT, and STRING be in the same order as each other between the grammar.mdk and spec files, too?

I see that match_kind was already mentioned in the text of the spec in Section 7.1, so this does look like it was simply an omission in the grammar.

| BIT
| INT
| STRING
Expand Down
1 change: 1 addition & 0 deletions p4-16/spec/grammar.mdk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,7 @@ specializedType
baseType
: BOOL
| ERROR
| MATCH_KIND
| STRING
| INT
| BIT
Expand Down