match_kind is a base type #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihai Budiu <[email protected]>
jafingerhut
reviewed
Feb 26, 2022
| @@ -1828,6 +1828,7 @@ P4 supports the following built-in base types: | |||
| baseType | |||
| : BOOL | |||
| | ERROR | |||
| | MATCH_KIND | |||
There was a problem hiding this comment.
Minor nit-pick, but should we go ahead and make the relative order of the other alternatives BIT, INT, and STRING be in the same order as each other between the grammar.mdk and spec files, too?
I see that match_kind was already mentioned in the text of the spec in Section 7.1, so this does look like it was simply an omission in the grammar.
jnfoster
approved these changes
Feb 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mihai Budiu [email protected]
See p4lang/p4c#3099 for several P4 programs that cannot be compiled without this change.