Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show default value for arg in help message #92

Merged
merged 11 commits into from
Dec 15, 2020
Merged

Show default value for arg in help message #92

merged 11 commits into from
Dec 15, 2020

Conversation

mishmish-dev
Copy link
Contributor

No description provided.

@mishmish-dev mishmish-dev changed the title #88 show default value in help GH#88 show default value in help Dec 15, 2020
@mishmish-dev mishmish-dev changed the title GH#88 show default value in help Show default value for arg in help message Dec 15, 2020
@mishmish-dev mishmish-dev mentioned this pull request Dec 15, 2020
Closed
p-ranav
p-ranav requested changes Dec 15, 2020
View reviewed changes
Copy link
Owner

@p-ranav p-ranav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some tests to validate this repr function

p-ranav
p-ranav requested changes Dec 15, 2020
View reviewed changes
Copy link
Owner

@p-ranav p-ranav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good. Build seems to fail on Mac?

@mishmish-dev
Copy link
Contributor Author

Tests look good. Build seems to fail on Mac?

Yes, you see, similar build error happened earlier. Looks to me like the compiler sometimes renders trait details::is_streamable_v<T> to true incorrectly and thus breaks SFINAE.

@p-ranav p-ranav merged commit 68fb9f1 into p-ranav:master Dec 15, 2020
@mishmish-dev
Copy link
Contributor Author

Sorry for spamming with commits and builds. The problematic piece was

decltype(std::declval<std::ostream&>() << std::declval<T>())

for trait is_streamable. I inserted that ampersand and all seem to work now. It's crazy that compilers behave differently.

Thank you for quick review and merge!

@p-ranav
Copy link
Owner

p-ranav commented Dec 15, 2020

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-ranav p-ranav p-ranav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mishmish-dev @p-ranav