Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce popup text overlapping using MessagesMap #635

Merged
merged 4 commits into from
Sep 23, 2020
Merged

Reduce popup text overlapping using MessagesMap #635

merged 4 commits into from
Sep 23, 2020

Conversation

ozkriff
Copy link
Owner

@ozkriff ozkriff commented Sep 22, 2020 •
edited
Loading

It's not perfect but seems good enough to reduce the most common popup text collisions.

This PR:

  • Adds MessagesMap to store text lifetimes during the event visualization.
  • Adds enum CommandOrigin { Player, Internal }.
  • Tweaks lot's of timings.
  • Removes a lot of action::Sleep from visualizer.rs.
  • Replaces some vec![] with plain [].
  • Removes "Vanish" message.

Closes #214 ("Reduce text overlapping")

@ozkriff ozkriff merged commit 4f6180b into master Sep 23, 2020
@ozkriff ozkriff deleted the i214_reduce_text_overlapping branch September 23, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce text overlapping
1 participant
@ozkriff