Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump syn build dependency to 2.0 #171

Closed
wants to merge 1 commit into from

Conversation

dylanahsmith
Copy link
Contributor

Closes #168, which is a dependabot PR that includes commits and release notes for context

@dylanahsmith
Copy link
Contributor Author

CI is failing for ubuntu-latest, since syn 2.0 uses rust edition 2021, which would be unstable for an old version of rust packaged for linux distros. So there may be a need to hold off on bumping syn while compatibility with those old rust versions is needed.

@ianks
Copy link
Collaborator

ianks commented Mar 24, 2023

Hmmm, our minimum supported rust version right now is 1.51. does that support 2021?

It does not seem to. I would like to get this PR in, but I think it may need to be for 1.0. The trouble with that is there are a number of breaking things we need to get in for 1.0 as well. Namely:

  1. Upgrade bindgen (which does have a few instances of breaking codegen for magnus, and probably rutie)
  2. Drop support for Ruby < 2.6
  3. Ability to provide pre-generated bindings to avoid bindgen dep (so we can use cargo-zig for cross compilation)

We can should get started on this though, but I'm fairly time-constrained at the moment so any help would be greatly appreciated!

@ianks ianks added this to the v1.0 milestone Mar 24, 2023
@matsadler matsadler mentioned this pull request Jun 20, 2023
@ianks ianks closed this Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants