Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bindgen to newest version #175

Closed
ianks opened this issue Mar 24, 2023 · 2 comments
Closed

Upgrade bindgen to newest version #175

ianks opened this issue Mar 24, 2023 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@ianks
Copy link
Collaborator

ianks commented Mar 24, 2023

As part of 1.0, we need to upgrade bindgen to the latest release. We can use this opportunity to make some breaking configuration changes if needed as long as we can keep our msrv 1.61

see matsadler/magnus#42

cc: @matsadler When do you expect to release 0.6? I would like to get 1.0 out first if possible to avoid having to support sub-optimal binding configs. Happy to integrate whatever breaking changes rb-sys introduces into magnus, though.

@ianks ianks added help wanted Extra attention is needed good first issue Good for newcomers labels Mar 24, 2023
@ianks ianks added this to the v1.0 milestone Mar 24, 2023
@matsadler
Copy link
Contributor

I'm hoping 0.6 will be done end of April/first week of May. Otherwise due to personal life commitments it'd probably end up middle of June.

I was actually going to ask to see if we could sync up a rb-sys 0.10/1.0 release with/before the Magnus 0.6 release. The other things I'd like to see would be changing VALUE to be an alias of usize (rather than platform dependent u32/u64), and updating syn to version 2 (I've already updated syn in Magnus' main branch. Things will work fine if rb-sys and Magnus use different versions, but it'd be nice if they were synced just to reduce the compilation time).

@ianks
Copy link
Collaborator Author

ianks commented Mar 24, 2023

Sounds good to me. Let's sync up, I'll message you on the oxidize-rb Slack

also, #171 has a patch for syn v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants