missing index on vpc_firewall_rule #983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-crespo
approved these changes
Apr 28, 2022
leftwo
pushed a commit
that referenced
this pull request
Oct 4, 2023
Crucible updates
all Crucible connections should set TCP_NODELAY (#983)
Use a fixed size for tag and nonce (#957)
Log crucible opts on start, order crutest options (#974)
Lock the Downstairs less (#966)
Cache dirty flag locally, reducing SQLite operations (#970)
Make stats mutex synchronous (#961)
Optimize requeue during flow control conditions (#962)
Update Rust crate base64 to 0.21.4 (#950)
Do less in control (#949)
Fix --flush-per-blocks (#959)
Fast dependency checking (#916)
Update actions/checkout action to v4 (#960)
Use `cargo hakari` for better workspace deps (#956)
Update actions/checkout digest to 8ade135 (#939)
Cache block size in Guest (#947)
Update Rust crate ringbuffer to 0.15.0 (#954)
Update Rust crate toml to 0.8 (#955)
Update Rust crate reedline to 0.24.0 (#953)
Update Rust crate libc to 0.2.148 (#952)
Update Rust crate indicatif to 0.17.7 (#951)
Remove unused async (#943)
Use a synchronous mutex for bw/iop_tokens (#946)
Make flush ID non-locking (#945)
Use `oneshot` channels instead of `mpsc` for notification (#918)
Use a strong type for upstairs negotiation (#941)
Add a "dynamometer" option to crucible-downstairs (#931)
Get new work and active count in one lock (#938)
A bunch of misc test cleanup stuff (#937)
Wait for a snapshot to finish on all downstairs (#920)
dsc and clippy cleanup. (#935)
No need to sort ackable_work (#934)
Use a strong type for repair ID (#928)
Keep new jobs sorted (#929)
Remove state_count function on Downstairs (#927)
Small cleanup to IOStateCount (#932)
let cmon and IOStateCount use ClientId (#930)
Fast return for zero length IOs (#926)
Use a strong type for client ID (#925)
A few Crucible Agent fixes (#922)
Use a newtype for `JobId` (#919)
Don't pass MutexGuard into functions (#917)
Crutest updates, rename tests, new options (#911)
Propolis updates
Update tungstenite crates to 0.20
Use `strum` crate for enum-related utilities
Wire up bits for CPUID customization
PHD: improve artifact store (#529)
Revert abort-on-panic in 'dev' cargo profile
leftwo
added a commit
that referenced
this pull request
Oct 5, 2023
Crucible updates
all Crucible connections should set TCP_NODELAY (#983)
Use a fixed size for tag and nonce (#957)
Log crucible opts on start, order crutest options (#974)
Lock the Downstairs less (#966)
Cache dirty flag locally, reducing SQLite operations (#970)
Make stats mutex synchronous (#961)
Optimize requeue during flow control conditions (#962)
Update Rust crate base64 to 0.21.4 (#950)
Do less in control (#949)
Fix --flush-per-blocks (#959)
Fast dependency checking (#916)
Update actions/checkout action to v4 (#960)
Use `cargo hakari` for better workspace deps (#956)
Update actions/checkout digest to 8ade135 (#939)
Cache block size in Guest (#947)
Update Rust crate ringbuffer to 0.15.0 (#954)
Update Rust crate toml to 0.8 (#955)
Update Rust crate reedline to 0.24.0 (#953)
Update Rust crate libc to 0.2.148 (#952)
Update Rust crate indicatif to 0.17.7 (#951)
Remove unused async (#943)
Use a synchronous mutex for bw/iop_tokens (#946)
Make flush ID non-locking (#945)
Use `oneshot` channels instead of `mpsc` for notification (#918)
Use a strong type for upstairs negotiation (#941)
Add a "dynamometer" option to crucible-downstairs (#931)
Get new work and active count in one lock (#938)
A bunch of misc test cleanup stuff (#937)
Wait for a snapshot to finish on all downstairs (#920)
dsc and clippy cleanup. (#935)
No need to sort ackable_work (#934)
Use a strong type for repair ID (#928)
Keep new jobs sorted (#929)
Remove state_count function on Downstairs (#927)
Small cleanup to IOStateCount (#932)
let cmon and IOStateCount use ClientId (#930)
Fast return for zero length IOs (#926)
Use a strong type for client ID (#925)
A few Crucible Agent fixes (#922)
Use a newtype for `JobId` (#919)
Don't pass MutexGuard into functions (#917)
Crutest updates, rename tests, new options (#911)
Propolis updates
Update tungstenite crates to 0.20
Use `strum` crate for enum-related utilities
Wire up bits for CPUID customization
PHD: improve artifact store (#529)
Revert abort-on-panic in 'dev' cargo profile
---------
Co-authored-by: Alan Hanson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#980 had me looking for tables with multiple partial indexes and I discovered that it looks like there was a copy/paste mistake in defining the indexes for
vpc_firewall_rule. In fact, we define the exact same index onvpc_routertwice instead. I looked quickly at the code paths around listing and updating firewall rules and I do believe that the index by (vpc_id,name) is correct.