[Reconfigurator] Make planner tests integration tests instead of unit tests #9455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tests There are no code changes to the planner tests themselves, other than reformatting (lost a level of nesting since they're no longer under `mod tests`). There are a couple minor changes to builder tests where it was calling back into helpers that used the planner; I think these checks are not necessary (and were actually testing the planner, not the builder). I duplicated the `verify_blueprint()` helper that just calls blippy and checks for notes. That seemed better than making it publicly available somewhere, but if others disagree I'm happy to do that instead.
davepacheco
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no code changes to the planner tests themselves, other than reformatting (lost a level of nesting since they're no longer under
mod tests). There are a couple minor changes to builder tests where it was calling back into helpers that used the planner; I think these checks are not necessary (and were actually testing the planner, not the builder).I duplicated the
verify_blueprint()helper that just calls blippy and checks for notes. That seemed better than making it publicly available somewhere, but if others disagree I'm happy to do that instead.We could break this new
planner.rsintegration test module up into submodules, but I'm not sure there's a meaningful grouping of different kinds of tests, so for now I just left them all in the one big file. I might revisit that later as I go through the tests to do other cleanup.