reconfigurator-cli: Expose a simulation state wrapper usable in tests #9456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgallagher
force-pushed
the
john/reconfigurator-cli-test-api-2
branch
from
1ae1e8c to
e01ec44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second attempt at #9442, pulling in the excellent feedback from @davepacheco and @sunshowers. It's staged on top of #9455.
Like #9442, this only updates a single test. Hopefully this is closer to what we really want; if so, I'll land this then work through the remaining planner tests (and add more helpers to
ReconfiguratorCliTestStateas needed).