Skip to content

Conversation

@sunshowers
Copy link
Contributor

@sunshowers sunshowers commented Oct 29, 2025

In #9275 we accidentally dropped assignments to variant. That caused upload-to-buildomat jobs to fail (example) with:

tools/upload_buildomat_junit_to_trunk.sh: line 189: variant: unbound variable

Restore assignments to this variable.

Created using spr 1.3.6-beta.1
@sunshowers sunshowers changed the title [ci] continue to assign variant after #9275 [ci] continue to assign variant after #9275 Oct 29, 2025
Created using spr 1.3.6-beta.1
@sunshowers
Copy link
Contributor Author

I feel like this script might already be at the point where it's too unwieldy for a shell script.

Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops.

@pietroalbini pietroalbini merged commit 41ccaad into main Oct 29, 2025
16 checks passed
@pietroalbini pietroalbini deleted the sunshowers/spr/ci-continue-to-assign-variant-after-9275 branch October 29, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants