Scrape the details page when determining which XML to upload to Trunk #9275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunshowers
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, to retrieve the XML file to upload from Buildomat to Trunk we relied on hardcoding the supported job names and using the artifacts published with Buildomat's
[[publish]].While investigating why Trunk wasn't marking tests as flaky (even after retrying the same job multiple times), Rain discovered that the published artifact remained the same even after retrying CI on the same commit. Turns out this was intended behavior, as Buildomat doesn't allow overriding already published artifacts.
To temporarily work around the problem, this PR switches the Trunk integration to scrape the HTML details page looking for
junit.xmlfiles. Hopefully once Buildomat provides a better way to retrieve the file we will be able to remove the hacky scraping code.More details on the rationale and the options considered is available in code comments.