Skip to content

Conversation

@davepacheco
Copy link
Collaborator

This PR contains two unrelated but tiny fixes:

  • Removes the Cargo dependency in omicron-nexus on nexus-client. This looks spurious and it causes ls-apis to think Nexus depends on itself.
  • Changes the new dev_only flag to use serde(default) instead of hand-rolling similar behavior (suggested by @sunshowers here).

Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely, looks good to me!

@davepacheco davepacheco enabled auto-merge (squash) November 21, 2024 19:55
@davepacheco davepacheco merged commit 43eaa52 into main Nov 21, 2024
17 checks passed
@davepacheco davepacheco deleted the dap/api-dag branch November 21, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants