-
Notifications
You must be signed in to change notification settings - Fork 62
fix ls-apis breakage
#7122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ls-apis breakage
#7122
Conversation
|
With just the check in place but no fix, the command fails as expected: |
sunshowers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
| /// human-readable notes about this API | ||
| pub notes: Option<String>, | ||
| /// whether this package is ever expected to be deployed in a real system | ||
| dev_only: Option<bool>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does None mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the comment to reflect that None means an API is deployed on real systems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah thanks. Worth using serde's default for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We definitely could. I don't have a strong feeling either way.
This PR:
ls-apisbroken due to the new clickhouse admin APIs #7121.These are separated into two commits if you want to see which part is which. They're in the reverse order -- I added the test first to make sure it would fail without the fix.
Fixes #7121.