Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SES-1486] Short voice message fix #1523

Merged
merged 31 commits into from
Jul 3, 2024
Merged

[SES-1486] Short voice message fix #1523

merged 31 commits into from
Jul 3, 2024

Commits on Jun 25, 2024

  1. Initial working push with debug comments

    @alansley
    alansley committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    3cdd383 View commit details
    Browse the repository at this point in the history

  2. Fixes #1522

    @alansley
    alansley committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    def1265 View commit details
    Browse the repository at this point in the history

  3. Cleanup, prevent multi-pointer recording, and don't show short msg to… 

    …ast if locked to record quickly
    @alansley
    alansley committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    c15a8ee View commit details
    Browse the repository at this point in the history

  4. Adjusted comment phrasing

    @alansley
    alansley committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    d9e1f73 View commit details
    Browse the repository at this point in the history

  5. Fix comment phrasing

    @alansley
    alansley committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    d5339b7 View commit details
    Browse the repository at this point in the history

  6. Fixed inadvertant short voice message toast on exit conversation acti… 

    …vity
    @alansley
    alansley committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    6bb760f View commit details
    Browse the repository at this point in the history

  7. Comment adjustment

    @alansley
    alansley committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    9e6c6af View commit details
    Browse the repository at this point in the history

  8. Comment phrasing

    @alansley
    alansley committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    753b49c View commit details
    Browse the repository at this point in the history

  9. Adjusted AudioRecorder.startRecording to take a callback function rat… 

    …her than the InputBar
    @alansley
    alansley committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    939694d View commit details
    Browse the repository at this point in the history

  10. Performed Thomas' PR feedback

    @alansley
    alansley committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    bd3655b View commit details
    Browse the repository at this point in the history

  11. Move comment to more relevant place

    @alansley
    alansley committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    d8799c9 View commit details
    Browse the repository at this point in the history

  12. Removed unused / leftover callback definition

    @alansley
    alansley committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    5d8fe27 View commit details
    Browse the repository at this point in the history

  13. Removed all redundant null checks after asserting binding is not null

    @alansley
    alansley committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    5858688 View commit details
    Browse the repository at this point in the history

  14. Removed remaining not-null assertions & added some logged feedback to… 

    … fail states
    @alansley
    alansley committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    880148f View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Addressed PR feedback

    @alansley
    alansley committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    bce6526 View commit details
    Browse the repository at this point in the history

  2. Implemented additional PR feedback

    @alansley
    alansley committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    e5371c5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'dev' into SES-1486_ShortVoiceMessageFix

    @alansley
    alansley committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    ae52e54 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2024

  1. Merge branch 'dev' into SES-1486_ShortVoiceMessageFix

    @AL-Session
    AL-Session committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    1c054b8 View commit details
    Browse the repository at this point in the history

  2. Adjusted InputBar property visibility as per PR feedback & adjusted T… 

    …oast string following discussion with Lucy
    @AL-Session
    AL-Session committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    bc13d20 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Minor adjustment to inform user if we see an obvious network issue wh… 

    …en sending a voice message - also tweak the locked Cancel button size to prevent text entry when locked to voice recording
    @AL-Session
    AL-Session committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    6f0277b View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Merge dev

    @alansley
    alansley committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    25d6982 View commit details
    Browse the repository at this point in the history

  2. Adjust comment phrasing following further testing

    @alansley
    alansley committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    5d9c242 View commit details
    Browse the repository at this point in the history

  3. Merge dev

    @alansley
    alansley committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    f2267e9 View commit details
    Browse the repository at this point in the history

  4. Added TODO comments to replace hard-coded string in toasts

    @alansley
    alansley committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    849a8f1 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Addressed Thomas PR feedback suggestion

    @alansley
    alansley committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    fea66bc View commit details
    Browse the repository at this point in the history

  2. Addressed another feedback suggestion

    @alansley
    alansley committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    e83b70c View commit details
    Browse the repository at this point in the history

  3. Adjustment to continue informing user of network / node path issues

    @alansley
    alansley committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    bd9fdc7 View commit details
    Browse the repository at this point in the history

  4. Improved & moved network check method

    @alansley
    alansley committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    50d3857 View commit details
    Browse the repository at this point in the history

  5. Corrected ticket number into TODO comments

    @alansley
    alansley committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    4ecda43 View commit details
    Browse the repository at this point in the history

  6. Addressed Andy PR feedback

    @alansley
    alansley committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    05e8fd8 View commit details
    Browse the repository at this point in the history

  7. Adjust network connectivity checks to just log issues rather than inf… 

    …orm the user (as per Rebecca / Kee convo)
    @alansley
    alansley committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    af55ae7 View commit details
    Browse the repository at this point in the history