[BUG] Very short voice messages can be sent #1522
Assignees
Labels
bug
Something isn't working
Comments
3 tasks
AL-Session
added a commit
that referenced
this issue
Jul 3, 2024
* Initial working push with debug comments * Fixes #1522 * Cleanup, prevent multi-pointer recording, and don't show short msg toast if locked to record quickly * Adjusted comment phrasing * Fix comment phrasing * Fixed inadvertant short voice message toast on exit conversation activity * Comment adjustment * Comment phrasing * Adjusted AudioRecorder.startRecording to take a callback function rather than the InputBar * Performed Thomas' PR feedback * Move comment to more relevant place * Removed unused / leftover callback definition * Removed all redundant null checks after asserting binding is not null * Removed remaining not-null assertions & added some logged feedback to fail states * Addressed PR feedback * Implemented additional PR feedback * Adjusted InputBar property visibility as per PR feedback & adjusted Toast string following discussion with Lucy * Minor adjustment to inform user if we see an obvious network issue when sending a voice message - also tweak the locked Cancel button size to prevent text entry when locked to voice recording * Adjust comment phrasing following further testing * Added TODO comments to replace hard-coded string in toasts * Addressed Thomas PR feedback suggestion * Addressed another feedback suggestion * Adjustment to continue informing user of network / node path issues * Improved & moved network check method * Corrected ticket number into TODO comments * Addressed Andy PR feedback * Adjust network connectivity checks to just log issues rather than inform the user (as per Rebecca / Kee convo) --------- Co-authored-by: alansley <[email protected]>
|
This issue (SES-1486) has been fixed and merged and will be incorporated into the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Code of conduct
Self-training on how to write a bug report
Is there an existing issue for this?
Current Behavior
If you press the microphone icon to record a voice message then as long as you held it long enough to trigger a "long press" event (a few hundred ms) but then immediately release it then that sub-1-second voice message will be sent - but any voice message less than a second is typically of little use.
Further, users who might not know that you need to press and hold the record voice message button may unintentionally send short voice messages to contacts.
Expected Behavior
Voice messages should have a minimum duration of 1 second, and any voice message less than this threshold should not be sent (instead, the user should be informed that their voice message is too short to send).
Steps To Reproduce
1.) Go to record a voice message but release the record voice message (microphone) button after about half a second,
2.) Half-second-ish voice message is sent.
Android Version
Android all
Session Version
1.18.4
Anything else?
This issue is tracked internally as SES-1486 and is addressed in the following branch (PR coming momentarily once I have this issue number to mark as fixed):
https://github.com/AL-Session/session-android/tree/SES-1486_ShortVoiceMessageFix
The text was updated successfully, but these errors were encountered: