SA429 Cannot save generic files #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x330a
suggested changes
Jan 15, 2024
| @@ -132,6 +132,9 @@ class VisibleMessageContentView : ConstraintLayout { | |||
| } | |||
|
|
|||
| if (message is MmsMessageRecord) { | |||
|
|
|||
| //if (message.isMediaPending) displaySpinnerDuringAttachmentDownload() | |||
There was a problem hiding this comment.
This one might be left over from before
| @@ -179,6 +182,12 @@ class VisibleMessageContentView : ConstraintLayout { | |||
| hideBody = true | |||
| // Document attachment | |||
| if (contactIsTrusted || message.isOutgoing) { | |||
| // Show the progress spinner if the attachment is downloading, otherwise show | |||
| // the document icon (and always remove the other, whichever one that is) | |||
| binding.documentView.documentViewProgress.visibility = if (message.isMediaPending) { VISIBLE } else { GONE } | |||
There was a problem hiding this comment.
we can probably push this one into the DocumentView.bind method, also check out this helper if that makes it easier :)
There was a problem hiding this comment.
Done & tested - all works nicely
| @@ -120,6 +119,8 @@ class VisibleMessageView : LinearLayout { | |||
| } | |||
| // endregion | |||
|
|
|||
| var messagesWeHaveBound = mutableListOf<Long>() | |||
0x330a
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Fixes #1234syntaxDescription
Attempting to download an attachment before the attachment has finished transferring from the network resulted in a toast with an error message being displayed ("Error while saving attachment to storage"). To fix this issue a check is performed about whether an attachment is still downloading or not, and if so and the user attempts to download the file before it's finished a toast says "Please wait until attachment has finished downloading".
Further, a spinner has been added to the message
VisibleMessageContentViewwhich replaces the generic file icon and animates a spinner during download, then when the attachment download has completed the generic 'file' icon replaces the spinner.All commits in this PR relate to fixing the same issue.