Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot Save Generic Files #429

Closed
trymeouteh opened this issue Feb 6, 2021 · 3 comments
Closed

Cannot Save Generic Files #429

trymeouteh opened this issue Feb 6, 2021 · 3 comments
Labels
bug Something isn't working good-first-issue Good issue for first time contributors

Comments

@trymeouteh
Copy link

Describe the bug

Cannot save generic files like ZIP files to phones storage

To reproduce

Send or recieve any file that is not a audio, video or image file (ZIP, 7z, txt)
Try to download this file to your phones storage

Screenshots or logs

If applicable, add screenshots or logs to help explain your problem.

Smartphone (please complete the following information):

  • Device: Samsung Galaxy S8
  • OS: Android 9
  • Sessions 1.6.12
@trymeouteh trymeouteh added the bug Something isn't working label Feb 6, 2021
@XZentus
Copy link

XZentus commented Mar 12, 2021 •
edited
Loading

Cannot save generic files like ZIP files to phones storage

To reproduce:

Send or receive any file that is not a audio, video or image file.

Device: Vivo 1915
OS: Funtouch OS_9.2
Sessions 1.6.12 .. 1.8.1

Error notification: "Error while saving attachment to storage!"
Permissions to storage granted.

@KeeJef KeeJef added the good-first-issue Good issue for first time contributors label Feb 6, 2023
@KeeJef
Copy link
Collaborator

KeeJef commented Feb 14, 2023

I can reproduce this with a ZIP file as of 1.16.5

alansley added a commit to alansley/session-android that referenced this issue Jan 12, 2024
@alansley
Fixes oxen-io#429
85417b7
alansley added a commit to alansley/session-android that referenced this issue Jan 14, 2024
@alansley
Fixes oxen-io#429
5a1bccb
0x330a pushed a commit that referenced this issue Jan 15, 2024
@alansley
Cannot save generic files (#1391)
2fff9ec 
* Fixes #429

* Further experimentation regarding potential race condition - still not resolved

* Changed spinner mechanism away from RotateAnimation which fixes race-condition

* Removed leftover commented code

* Cleanup of unused imports

* Addressed PR feedback

* Adjusted 'visible' to use ktx
@0x330a
Copy link

0x330a commented Jan 15, 2024

I believe this was caused by pending attachments that hadn't fully downloaded yet, with no clear indicator in the UI. Fixed by showing a progress in #1391 and also a toast when trying to download attachments that aren't completed yet

@0x330a 0x330a closed this as completed Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good-first-issue Good issue for first time contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@XZentus @KeeJef @trymeouteh @0x330a