Skip to content

fix(semantic): insert binding into correct scope for TSInferType#9567

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/fix-infer-scope
Mar 5, 2025
Merged

fix(semantic): insert binding into correct scope for TSInferType#9567
graphite-app[bot] merged 1 commit intomainfrom
c/fix-infer-scope

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Mar 5, 2025

No description provided.

Copy link
Contributor Author

camc314 commented Mar 5, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-semantic Area - Semantic A-isolated-declarations Isolated Declarations C-bug Category - Bug labels Mar 5, 2025
@camc314 camc314 marked this pull request as ready for review March 5, 2025 15:11
@camc314 camc314 requested review from Boshen and Dunqing as code owners March 5, 2025 15:11
@camc314 camc314 force-pushed the c/fix-infer-scope branch 2 times, most recently from 9c25885 to 42d6dec Compare March 5, 2025 15:16
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 5, 2025

CodSpeed Performance Report

Merging #9567 will not alter performance

Comparing c/fix-infer-scope (bbb4f98) with main (be5e5dc)

Summary

✅ 39 untouched benchmarks

@camc314 camc314 force-pushed the c/fix-infer-scope branch 2 times, most recently from c99e687 to e9f1f62 Compare March 5, 2025 15:23
@camc314 camc314 force-pushed the c/fix-infer-scope branch 2 times, most recently from 491d294 to 47d7849 Compare March 5, 2025 16:49
@github-actions github-actions bot added the A-ast Area - AST label Mar 5, 2025
@camc314 camc314 force-pushed the c/fix-infer-scope branch from 47d7849 to e94fe89 Compare March 5, 2025 16:50
@camc314 camc314 requested a review from Dunqing March 5, 2025 16:50
Copy link
Member

@Dunqing Dunqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The last thing is to update snapshots!

@camc314 camc314 force-pushed the c/fix-infer-scope branch from e94fe89 to a5a10b2 Compare March 5, 2025 16:57
@camc314 camc314 changed the title fix(semantic): correctly resolve type ref in TSInfer fix(semantic): insert binding into correct scope for TSInferType Mar 5, 2025
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 5, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 5, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the c/fix-infer-scope branch from a5a10b2 to bbb4f98 Compare March 5, 2025 17:03
@graphite-app graphite-app bot merged commit bbb4f98 into main Mar 5, 2025
32 checks passed
@graphite-app graphite-app bot deleted the c/fix-infer-scope branch March 5, 2025 17:08
@oxc-bot oxc-bot mentioned this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST A-isolated-declarations Isolated Declarations A-semantic Area - Semantic C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants