feat(ast)!: add scope_id to TSFunctionType

[camc314]

fixes #9558

[camc314]

• feat(ast)!: add scope_id to TSFunctionType #9559 👈 (View in Graphite)
• fix(semantic): insert binding into correct scope for TSInferType #9567
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #9559 will create unknown performance changes

_{Comparing c/03-05-feat_ast_add_scope_id_to_tsfunctiontype_ (48a0394) with main (bbb4f98)}

Summary

🆕 39 new benchmarks

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
🆕	parser_napi[RadixUIAdoptionSection.jsx]	N/A	4.8 ms	N/A
🆕	parser_napi[pdf.mjs]	N/A	1.8 s	N/A
🆕	parser_napi_raw[RadixUIAdoptionSection.jsx]	N/A	1.3 ms	N/A
🆕	parser_napi_raw[cal.com.tsx]	N/A	699.1 ms	N/A
🆕	parser_napi_raw[checker.ts]	N/A	1.1 s	N/A
🆕	parser_napi_raw[pdf.mjs]	N/A	266.3 ms	N/A
🆕	codegen[checker.ts]	N/A	23.1 ms	N/A
🆕	codegen_sourcemap[checker.ts]	N/A	66.1 ms	N/A
🆕	isolated-declarations[vue-id.ts]	N/A	58.7 ms	N/A
🆕	lexer[RadixUIAdoptionSection.jsx]	N/A	21 µs	N/A
🆕	lexer[antd.js]	N/A	24.1 ms	N/A
🆕	lexer[cal.com.tsx]	N/A	5.7 ms	N/A
🆕	lexer[checker.ts]	N/A	14.5 ms	N/A
🆕	lexer[pdf.mjs]	N/A	3.8 ms	N/A
🆕	linter[RadixUIAdoptionSection.jsx]	N/A	2.7 ms	N/A
🆕	linter[cal.com.tsx]	N/A	1.2 s	N/A
🆕	linter[checker.ts]	N/A	2.9 s	N/A
🆕	mangler[antd.js]	N/A	16.1 ms	N/A
🆕	mangler[react.development.js]	N/A	294.9 µs	N/A
🆕	mangler[typescript.js]	N/A	39.7 ms	N/A
...	...	...	...	...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

[Dunqing]

The way to fix is correct, just need to figure out how Typescript solves that fails case. The TypeScript implementation is here https://github.com/microsoft/TypeScript/blob/d8086f14b6b97c0df34a0cc2f56d4b5926a0c299/src/compiler/binder.ts#L3883-L3962

Also can you add a test to https://github.com/oxc-project/oxc/blob/0928a192ee3c2901260c88610ea961de4d885703/crates/oxc_isolated_declarations/tests/fixtures/eliminate-imports.ts?

[Dunqing]

I found out how TypeScript handles infer X. The binding of infer should be always inserted into the TSConditionalType scope. So we need to do some check for TSInferType's TSTypeParameter in

oxc/crates/oxc_semantic/src/binder.rs

Lines 441 to 449 in aa3319e

	fn bind(&self, builder: &mut SemanticBuilder) {
	let symbol_id = builder.declare_symbol(
	self.name.span,
	&self.name.name,
	SymbolFlags::TypeParameter,
	SymbolFlags::TypeParameterExcludes,
	);
	self.name.symbol_id.set(Some(symbol_id));
	}

This should be changed first in another PR.

[camc314]

yes, 🙂 i'm working on this in a bit. Copying typescript-eslint's implementation

[camc314]

@Dunqing please take a look when you've time 🙏 should be correct now

[Dunqing]

actually the oxc behaviour here is correct. https://www.typescriptlang.org/play/?#code/KYDwDg9gTgLgBDAnmYcCCAeAQgPjgXjizlBmADsATAZzgG84BbYGACwkoAowBDKHxgC44AS3IAzYFDgBhOAEphANwgjKcAL5wA-AigBXVMJkBuIA

Oh, I am sorry, I forgot the falseType of TSConditionalType cannot refer to TSInferType, so the correct example is https://www.typescriptlang.org/play/?#code/KYDwDg9gTgLgBDAnmYcCCAeAQgPjgXjizlBmADsATAZzgG84BbYGACwkoAowBDKHxgC44AS3IAzYFDgBhOAEphANwgjKcAL5wA-LLjDywJVIDcQA

[Dunqing]

Merge activity

• Mar 5, 12:00 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Mar 5, 12:03 PM EST: A user added this pull request to the Graphite merge queue.
• Mar 5, 12:12 PM EST: A user merged this pull request with the Graphite merge queue.

[camc314]

thank you @Dunqing for your detailed reviews! 🙏