Skip to content

fix(minifier): keep indirect access for delete and typeof#9563

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-05-feat_minifier_keep_indirect_access_for_delete_and_typeof_
Mar 5, 2025
Merged

fix(minifier): keep indirect access for delete and typeof#9563
graphite-app[bot] merged 1 commit intomainfrom
03-05-feat_minifier_keep_indirect_access_for_delete_and_typeof_

Conversation

@sapphi-red
Copy link
Copy Markdown
Member

@sapphi-red sapphi-red commented Mar 5, 2025

delete (0, a.b) / typeof (0, a) was not kept as-is, but it should be.

Copy link
Copy Markdown
Member Author

sapphi-red commented Mar 5, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Mar 5, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 5, 2025

CodSpeed Performance Report

Merging #9563 will create unknown performance changes

Comparing 03-05-feat_minifier_keep_indirect_access_for_delete_and_typeof_ (7a220a3) with main (a92b863)

Summary

🆕 39 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 parser_napi[RadixUIAdoptionSection.jsx] N/A 4.8 ms N/A
🆕 parser_napi[pdf.mjs] N/A 1.8 s N/A
🆕 parser_napi_raw[RadixUIAdoptionSection.jsx] N/A 1.3 ms N/A
🆕 parser_napi_raw[cal.com.tsx] N/A 700.1 ms N/A
🆕 parser_napi_raw[checker.ts] N/A 1.1 s N/A
🆕 parser_napi_raw[pdf.mjs] N/A 266.4 ms N/A
🆕 codegen[checker.ts] N/A 23.1 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 66.2 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 57.9 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 20.9 µs N/A
🆕 lexer[antd.js] N/A 24.1 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.7 ms N/A
🆕 lexer[checker.ts] N/A 14.5 ms N/A
🆕 lexer[pdf.mjs] N/A 3.8 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 2.9 s N/A
🆕 mangler[antd.js] N/A 16.1 ms N/A
🆕 mangler[react.development.js] N/A 295 µs N/A
🆕 mangler[typescript.js] N/A 39.7 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@sapphi-red sapphi-red changed the title feat(minifier): keep indirect access for delete and typeof fix(minifier): keep indirect access for delete and typeof Mar 5, 2025
@github-actions github-actions bot added the C-bug Category - Bug label Mar 5, 2025
@sapphi-red sapphi-red marked this pull request as ready for review March 5, 2025 12:53
@sapphi-red sapphi-red removed the C-enhancement Category - New feature or request label Mar 5, 2025
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Mar 5, 2025
Copy link
Copy Markdown
Member

Boshen commented Mar 5, 2025

Merge activity

  • Mar 5, 8:14 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 5, 8:14 AM EST: A user added this pull request to the Graphite merge queue.
  • Mar 5, 8:22 AM EST: A user merged this pull request with the Graphite merge queue.

`delete (0, a.b)` / `typeof (0, a)` was not kept as-is, but it should be.
@graphite-app graphite-app bot force-pushed the 03-05-feat_minifier_keep_indirect_access_more_precisely branch from 6701f66 to a92b863 Compare March 5, 2025 13:14
@graphite-app graphite-app bot force-pushed the 03-05-feat_minifier_keep_indirect_access_for_delete_and_typeof_ branch from 6d9eede to 7a220a3 Compare March 5, 2025 13:15
Base automatically changed from 03-05-feat_minifier_keep_indirect_access_more_precisely to main March 5, 2025 13:19
@graphite-app graphite-app bot merged commit 7a220a3 into main Mar 5, 2025
33 checks passed
@graphite-app graphite-app bot deleted the 03-05-feat_minifier_keep_indirect_access_for_delete_and_typeof_ branch March 5, 2025 13:22
Boshen pushed a commit that referenced this pull request Mar 5, 2025
`delete (0, a.b)` / `typeof (0, a)` was not kept as-is, but it should be.
@oxc-bot oxc-bot mentioned this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants