Skip to content

feat(minifier): keep indirect access more precisely#9562

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-05-feat_minifier_keep_indirect_access_more_precisely
Mar 5, 2025
Merged

feat(minifier): keep indirect access more precisely#9562
graphite-app[bot] merged 1 commit intomainfrom
03-05-feat_minifier_keep_indirect_access_more_precisely

Conversation

@sapphi-red
Copy link
Copy Markdown
Member

@sapphi-red sapphi-red commented Mar 5, 2025

Compress (1 ? a.b : 0)() to (0, a.b)().
Also fixes (null ?? a.b)() being compressed to a.b() (now it'll be (0, a.b)() instead).

Copy link
Copy Markdown
Member Author

sapphi-red commented Mar 5, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Mar 5, 2025
@sapphi-red sapphi-red marked this pull request as ready for review March 5, 2025 12:50
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 5, 2025

CodSpeed Performance Report

Merging #9562 will degrade performances by 3.21%

Comparing 03-05-feat_minifier_keep_indirect_access_more_precisely (a92b863) with main (b7f82fc)

Summary

❌ 1 regressions
✅ 38 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
minifier[react.development.js] 1.8 ms 1.8 ms -3.21%

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 5, 2025
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented Mar 5, 2025

Merge activity

Compress `(1 ? a.b : 0)()` to `(0, a.b)()`.
Also fixes `(null ?? a.b)()` being compressed to `a.b()` (now it'll be `(0, a.b)()` instead).
@graphite-app graphite-app bot force-pushed the 03-05-feat_minifier_keep_indirect_access_more_precisely branch from 6701f66 to a92b863 Compare March 5, 2025 13:14
@graphite-app graphite-app bot merged commit a92b863 into main Mar 5, 2025
32 checks passed
@graphite-app graphite-app bot deleted the 03-05-feat_minifier_keep_indirect_access_more_precisely branch March 5, 2025 13:19
Boshen pushed a commit that referenced this pull request Mar 5, 2025
Compress `(1 ? a.b : 0)()` to `(0, a.b)()`.
Also fixes `(null ?? a.b)()` being compressed to `a.b()` (now it'll be `(0, a.b)()` instead).
@oxc-bot oxc-bot mentioned this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-minifier Area - Minifier C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant