perf(mangler): use shorter InlineString#9552
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 5, 2025
Merged
Conversation
This was referenced Mar 4, 2025
Merged
Member
Author
CodSpeed Performance ReportMerging #9552 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
Member
Author
|
Damn. Only +0.2% perf improvement. |
camchenry
approved these changes
Mar 5, 2025
Member
camchenry
left a comment
There was a problem hiding this comment.
Maybe a small improvement but still worth it I think.
Member
Merge activity
|
`SymbolId` is a `u32`, so there are a maximum of `u32::MAX` symbols. Therefore the longest mangled symbol name is 6 characters (`xKrTKr` for `u32::MAX`). Use an 8-byte `InlineString` for symbol names (instead of 16 bytes). Also, enable the tests for `oxc_mangler` crate. The tests were previously failing, but we didn't notice because they were disabled.
9c22f36 to
c1a8cea
Compare
1dce342 to
bc14ee5
Compare
Base automatically changed from
03-04-refactor_ast_estree_simplify_serializing_regexpliteral_s
to
main
March 5, 2025 02:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

SymbolIdis au32, so there are a maximum ofu32::MAXsymbols. Therefore the longest mangled symbol name is 6 characters (xKrTKrforu32::MAX).Use an 8-byte
InlineStringfor symbol names (instead of 16 bytes).Also, enable the tests for
oxc_manglercrate. The tests were previously failing, but we didn't notice because they were disabled.