Skip to content

refactor(ast): RegExpFlags::to_string return flags in alphabetical order#9548

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-04-refactor_ast_regexpflags_to_string_return_flags_in_alphabetical_order
Mar 5, 2025
Merged

refactor(ast): RegExpFlags::to_string return flags in alphabetical order#9548
graphite-app[bot] merged 1 commit intomainfrom
03-04-refactor_ast_regexpflags_to_string_return_flags_in_alphabetical_order

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 4, 2025

RegExpFlags::to_string return flags in alphabetical order, the way V8 does.

Copy link
Member Author

overlookmotel commented Mar 4, 2025

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 4, 2025

CodSpeed Performance Report

Merging #9548 will create unknown performance changes

Comparing 03-04-refactor_ast_regexpflags_to_string_return_flags_in_alphabetical_order (734b6b6) with main (a9889f5)

Summary

🆕 39 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 parser_napi[RadixUIAdoptionSection.jsx] N/A 4.8 ms N/A
🆕 parser_napi[pdf.mjs] N/A 1.8 s N/A
🆕 parser_napi_raw[RadixUIAdoptionSection.jsx] N/A 1.3 ms N/A
🆕 parser_napi_raw[cal.com.tsx] N/A 699 ms N/A
🆕 parser_napi_raw[checker.ts] N/A 1.1 s N/A
🆕 parser_napi_raw[pdf.mjs] N/A 266.5 ms N/A
🆕 codegen[checker.ts] N/A 23.1 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 66.2 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 57.8 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 20.9 µs N/A
🆕 lexer[antd.js] N/A 24.1 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.7 ms N/A
🆕 lexer[checker.ts] N/A 14.5 ms N/A
🆕 lexer[pdf.mjs] N/A 3.8 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 2.9 s N/A
🆕 mangler[antd.js] N/A 16.1 ms N/A
🆕 mangler[react.development.js] N/A 297.6 µs N/A
🆕 mangler[typescript.js] N/A 39.8 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 5, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 5, 2025

Merge activity

…order (#9548)

`RegExpFlags::to_string` return flags in alphabetical order, the way V8 does.
@graphite-app graphite-app bot force-pushed the 03-04-feat_ast_estree_property_have_consistent_field_order branch from 9c37750 to af02a87 Compare March 5, 2025 02:22
@graphite-app graphite-app bot force-pushed the 03-04-refactor_ast_regexpflags_to_string_return_flags_in_alphabetical_order branch from 70b88e0 to 734b6b6 Compare March 5, 2025 02:22
Base automatically changed from 03-04-feat_ast_estree_property_have_consistent_field_order to main March 5, 2025 02:38
@graphite-app graphite-app bot merged commit 734b6b6 into main Mar 5, 2025
34 checks passed
@graphite-app graphite-app bot deleted the 03-04-refactor_ast_regexpflags_to_string_return_flags_in_alphabetical_order branch March 5, 2025 02:41
@oxc-bot oxc-bot mentioned this pull request Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants