Skip to content

feat(linter): promote eslint/no-eval to correctness #9231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Boshen merged 3 commits into from
Feb 19, 2025
Merged

feat(linter): promote eslint/no-eval to correctness #9231

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e39af2
refactor(linter): improve eslint/no-eval
shulaoda Feb 19, 2025
1840d87
chore: update snapshots
shulaoda Feb 19, 2025
6224d2d
chore: revert dignostic message
shulaoda Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ore-path fixtures__linter__.customignore --no-ignore fixtures__linter__nan.js@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ working directory:
help: Use the isNaN function to compare with NaN.

Found 1 warning and 0 errors.
Finished in <variable>ms on 1 file with 97 rules using 1 threads.
Finished in <variable>ms on 1 file with 98 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
2 changes: 1 addition & 1 deletion ...pshots/_--ignore-pattern _____.js --ignore-pattern _____.vue fixtures__linter@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ arguments: --ignore-pattern **/*.js --ignore-pattern **/*.vue fixtures/linter
working directory:
----------
Found 0 warnings and 0 errors.
Finished in <variable>ms on 0 files with 97 rules using 1 threads.
Finished in <variable>ms on 0 files with 98 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
2 changes: 1 addition & 1 deletion apps/oxlint/src/snapshots/_--import-plugin -A all -D no-cycle fixtures__flow__@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ arguments: --import-plugin -A all -D no-cycle fixtures/flow/
working directory:
----------
Found 0 warnings and 0 errors.
Finished in <variable>ms on 2 files with 99 rules using 1 threads.
Finished in <variable>ms on 2 files with 100 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
2 changes: 1 addition & 1 deletion apps/oxlint/src/snapshots/_--import-plugin fixtures__flow__index.mjs@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ arguments: --import-plugin fixtures/flow/index.mjs
working directory:
----------
Found 0 warnings and 0 errors.
Finished in <variable>ms on 1 file with 99 rules using 1 threads.
Finished in <variable>ms on 1 file with 100 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
2 changes: 1 addition & 1 deletion ..._vitest_replace__eslintrc.json fixtures__eslintrc_vitest_replace__foo.test.js@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ working directory:
help: Remove the appending `.skip`

Found 1 warning and 1 error.
Finished in <variable>ms on 1 file with 109 rules using 1 threads.
Finished in <variable>ms on 1 file with 110 rules using 1 threads.
----------
CLI result: LintFoundErrors
----------
2 changes: 1 addition & 1 deletion apps/oxlint/src/snapshots/_-D correctness fixtures__linter__debugger.js@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ working directory:
help: Delete this code.

Found 0 warnings and 1 error.
Finished in <variable>ms on 1 file with 97 rules using 1 threads.
Finished in <variable>ms on 1 file with 98 rules using 1 threads.
----------
CLI result: LintFoundErrors
----------
2 changes: 1 addition & 1 deletion ...nt/src/snapshots/_-W correctness -A no-debugger fixtures__linter__debugger.js@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ arguments: -W correctness -A no-debugger fixtures/linter/debugger.js
working directory:
----------
Found 0 warnings and 0 errors.
Finished in <variable>ms on 1 file with 96 rules using 1 threads.
Finished in <variable>ms on 1 file with 97 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
2 changes: 1 addition & 1 deletion ... fixtures__eslintrc_env__eslintrc_no_env.json fixtures__eslintrc_env__test.js@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ working directory:
`----

Found 1 warning and 0 errors.
Finished in <variable>ms on 1 file with 98 rules using 1 threads.
Finished in <variable>ms on 1 file with 99 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
2 changes: 1 addition & 1 deletion ..._-W no-undef -c fixtures__no_undef__eslintrc.json fixtures__no_undef__test.js@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ working directory:
`----

Found 1 warning and 0 errors.
Finished in <variable>ms on 1 file with 98 rules using 1 threads.
Finished in <variable>ms on 1 file with 99 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
2 changes: 1 addition & 1 deletion ...e_extension__eslintrc.json fixtures__config_ignore_patterns__ignore_extension@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ working directory:
help: Delete this file or add some code to it.

Found 1 warning and 0 errors.
Finished in <variable>ms on 1 file with 97 rules using 1 threads.
Finished in <variable>ms on 1 file with 98 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
2 changes: 1 addition & 1 deletion ...ures__eslintrc_env__eslintrc_env_browser.json fixtures__eslintrc_env__test.js@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ arguments: -c fixtures/eslintrc_env/eslintrc_env_browser.json fixtures/eslintrc_
working directory:
----------
Found 0 warnings and 0 errors.
Finished in <variable>ms on 1 file with 98 rules using 1 threads.
Finished in <variable>ms on 1 file with 99 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
2 changes: 1 addition & 1 deletion ...ots/_-c fixtures__eslintrc_off__eslintrc.json fixtures__eslintrc_off__test.js@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ working directory:
help: Delete this file or add some code to it.

Found 1 warning and 0 errors.
Finished in <variable>ms on 1 file with 97 rules using 1 threads.
Finished in <variable>ms on 1 file with 98 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
2 changes: 1 addition & 1 deletion ..._vitest_replace__eslintrc.json fixtures__eslintrc_vitest_replace__foo.test.js@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ arguments: -c fixtures/eslintrc_vitest_replace/eslintrc.json fixtures/eslintrc_v
working directory:
----------
Found 0 warnings and 0 errors.
Finished in <variable>ms on 1 file with 97 rules using 1 threads.
Finished in <variable>ms on 1 file with 98 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
2 changes: 1 addition & 1 deletion ...c/snapshots/_-c fixtures__linter__eslintrc.json fixtures__linter__debugger.js@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ working directory:
help: Delete this code.

Found 0 warnings and 1 error.
Finished in <variable>ms on 1 file with 97 rules using 1 threads.
Finished in <variable>ms on 1 file with 98 rules using 1 threads.
----------
CLI result: LintFoundErrors
----------
2 changes: 1 addition & 1 deletion ..._-c fixtures__no_console_off__eslintrc.json fixtures__no_console_off__test.js@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ arguments: -c fixtures/no_console_off/eslintrc.json fixtures/no_console_off/test
working directory:
----------
Found 0 warnings and 0 errors.
Finished in <variable>ms on 1 file with 97 rules using 1 threads.
Finished in <variable>ms on 1 file with 98 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
2 changes: 1 addition & 1 deletion ...atch__eslintrc.json -W no-empty fixtures__no_empty_allow_empty_catch__test.js@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ arguments: -c fixtures/no_empty_allow_empty_catch/eslintrc.json -W no-empty fixt
working directory:
----------
Found 0 warnings and 0 errors.
Finished in <variable>ms on 1 file with 98 rules using 1 threads.
Finished in <variable>ms on 1 file with 99 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
2 changes: 1 addition & 1 deletion ...h__eslintrc.json -W no-empty fixtures__no_empty_disallow_empty_catch__test.js@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ working directory:
help: Remove this block or add a comment inside it

Found 1 warning and 0 errors.
Finished in <variable>ms on 1 file with 98 rules using 1 threads.
Finished in <variable>ms on 1 file with 99 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
6 changes: 3 additions & 3 deletions ...test.ts -c fixtures__overrides__.oxlintrc.json fixtures__overrides__other.jsx@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ working directory:
help: Replace var with let or const

Found 0 warnings and 1 error.
Finished in <variable>ms on 1 file with 99 rules using 1 threads.
Finished in <variable>ms on 1 file with 100 rules using 1 threads.
----------
CLI result: LintFoundErrors
----------
Expand All @@ -42,7 +42,7 @@ working directory:
help: Delete this console statement.

Found 1 warning and 1 error.
Finished in <variable>ms on 1 file with 99 rules using 1 threads.
Finished in <variable>ms on 1 file with 100 rules using 1 threads.
----------
CLI result: LintFoundErrors
----------
Expand All @@ -61,7 +61,7 @@ working directory:
help: Replace var with let or const

Found 0 warnings and 1 error.
Finished in <variable>ms on 1 file with 99 rules using 1 threads.
Finished in <variable>ms on 1 file with 100 rules using 1 threads.
----------
CLI result: LintFoundErrors
----------
2 changes: 1 addition & 1 deletion ...napshots/_-c fixtures__overrides__directories-config.json fixtures__overrides@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ working directory:
help: Delete this code.

Found 2 warnings and 2 errors.
Finished in <variable>ms on 7 files with 96 rules using 1 threads.
Finished in <variable>ms on 7 files with 97 rules using 1 threads.
----------
CLI result: LintFoundErrors
----------
2 changes: 1 addition & 1 deletion ...slintrc.json --disable-typescript-plugin fixtures__typescript_eslint__test.ts@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ working directory:
`----

Found 1 warning and 1 error.
Finished in <variable>ms on 1 file with 48 rules using 1 threads.
Finished in <variable>ms on 1 file with 49 rules using 1 threads.
----------
CLI result: LintFoundErrors
----------
2 changes: 1 addition & 1 deletion ...xtures__typescript_eslint__eslintrc.json fixtures__typescript_eslint__test.ts@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ working directory:
`----

Found 2 warnings and 1 error.
Finished in <variable>ms on 1 file with 59 rules using 1 threads.
Finished in <variable>ms on 1 file with 60 rules using 1 threads.
----------
CLI result: LintFoundErrors
----------
2 changes: 1 addition & 1 deletion apps/oxlint/src/snapshots/_fixtures__astro__debugger.astro@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ working directory:
help: Delete this code.

Found 4 warnings and 0 errors.
Finished in <variable>ms on 1 file with 97 rules using 1 threads.
Finished in <variable>ms on 1 file with 98 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
2 changes: 1 addition & 1 deletion apps/oxlint/src/snapshots/_fixtures__linter@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ working directory:
help: Use the isNaN function to compare with NaN.

Found 3 warnings and 0 errors.
Finished in <variable>ms on 3 files with 97 rules using 1 threads.
Finished in <variable>ms on 3 files with 98 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
2 changes: 1 addition & 1 deletion .../oxlint/src/snapshots/_fixtures__linter__debugger.js fixtures__linter__nan.js@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ working directory:
help: Use the isNaN function to compare with NaN.

Found 2 warnings and 0 errors.
Finished in <variable>ms on 2 files with 97 rules using 1 threads.
Finished in <variable>ms on 2 files with 98 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
2 changes: 1 addition & 1 deletion apps/oxlint/src/snapshots/_fixtures__linter__debugger.js@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ working directory:
help: Delete this code.

Found 1 warning and 0 errors.
Finished in <variable>ms on 1 file with 97 rules using 1 threads.
Finished in <variable>ms on 1 file with 98 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
2 changes: 1 addition & 1 deletion apps/oxlint/src/snapshots/_fixtures__svelte__debugger.svelte@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ working directory:
help: Delete this code.

Found 1 warning and 0 errors.
Finished in <variable>ms on 1 file with 97 rules using 1 threads.
Finished in <variable>ms on 1 file with 98 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
2 changes: 1 addition & 1 deletion apps/oxlint/src/snapshots/_fixtures__vue__debugger.vue@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ working directory:
help: Delete this code.

Found 2 warnings and 0 errors.
Finished in <variable>ms on 1 file with 97 rules using 1 threads.
Finished in <variable>ms on 1 file with 98 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
2 changes: 1 addition & 1 deletion apps/oxlint/src/snapshots/_fixtures__vue__empty.vue@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ arguments: fixtures/vue/empty.vue
working directory:
----------
Found 0 warnings and 0 errors.
Finished in <variable>ms on 1 file with 97 rules using 1 threads.
Finished in <variable>ms on 1 file with 98 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
2 changes: 1 addition & 1 deletion apps/oxlint/src/snapshots/_foo.asdf@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ arguments: foo.asdf
working directory:
----------
Found 0 warnings and 0 errors.
Finished in <variable>ms on 0 files with 97 rules using 1 threads.
Finished in <variable>ms on 0 files with 98 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
2 changes: 1 addition & 1 deletion apps/oxlint/src/snapshots/fixtures__auto_config_detection_debugger.js@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ working directory: fixtures/auto_config_detection
help: Delete this code.

Found 0 warnings and 1 error.
Finished in <variable>ms on 1 file with 97 rules using 1 threads.
Finished in <variable>ms on 1 file with 98 rules using 1 threads.
----------
CLI result: LintFoundErrors
----------
2 changes: 1 addition & 1 deletion ...snapshots/fixtures__config_ignore_patterns__ignore_directory_-c eslintrc.json@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ working directory: fixtures/config_ignore_patterns/ignore_directory
help: Delete this file or add some code to it.

Found 1 warning and 0 errors.
Finished in <variable>ms on 1 file with 97 rules using 1 threads.
Finished in <variable>ms on 1 file with 98 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
2 changes: 1 addition & 1 deletion ...ore_patterns__with_oxlintrc_-c .__test__eslintrc.json --ignore-pattern _.ts .@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ working directory: fixtures/config_ignore_patterns/with_oxlintrc
help: Delete this file or add some code to it.

Found 1 warning and 0 errors.
Finished in <variable>ms on 1 file with 97 rules using 1 threads.
Finished in <variable>ms on 1 file with 98 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
4 changes: 2 additions & 2 deletions ...lias_rules_-c .oxlintrc-eslint.json test.js -c .oxlintrc-unicorn.json test.js@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ arguments: -c .oxlintrc-eslint.json test.js
working directory: fixtures/disable_eslint_and_unicorn_alias_rules
----------
Found 0 warnings and 0 errors.
Finished in <variable>ms on 1 file with 48 rules using 1 threads.
Finished in <variable>ms on 1 file with 49 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
Expand All @@ -16,7 +16,7 @@ arguments: -c .oxlintrc-unicorn.json test.js
working directory: fixtures/disable_eslint_and_unicorn_alias_rules
----------
Found 0 warnings and 0 errors.
Finished in <variable>ms on 1 file with 61 rules using 1 threads.
Finished in <variable>ms on 1 file with 62 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
4 changes: 2 additions & 2 deletions ...fixtures__import_-c .oxlintrc.json test.js -c .oxlintrc-import-x.json test.js@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ working directory: fixtures/import
`----

Found 0 warnings and 1 error.
Finished in <variable>ms on 1 file with 50 rules using 1 threads.
Finished in <variable>ms on 1 file with 51 rules using 1 threads.
----------
CLI result: LintFoundErrors
----------
Expand All @@ -34,7 +34,7 @@ working directory: fixtures/import
`----

Found 0 warnings and 1 error.
Finished in <variable>ms on 1 file with 50 rules using 1 threads.
Finished in <variable>ms on 1 file with 51 rules using 1 threads.
----------
CLI result: LintFoundErrors
----------
2 changes: 1 addition & 1 deletion apps/oxlint/src/snapshots/fixtures__linter_debugger.js@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ working directory: fixtures/linter
help: Delete this code.

Found 1 warning and 0 errors.
Finished in <variable>ms on 1 file with 97 rules using 1 threads.
Finished in <variable>ms on 1 file with 98 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
2 changes: 1 addition & 1 deletion .../src/snapshots/fixtures__output_formatter_diagnostic_--format=default test.js@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ working directory: fixtures/output_formatter_diagnostic
help: Delete this code.

Found 2 warnings and 1 error.
Finished in <variable>ms on 1 file with 97 rules using 1 threads.
Finished in <variable>ms on 1 file with 98 rules using 1 threads.
----------
CLI result: LintFoundErrors
----------
2 changes: 1 addition & 1 deletion apps/oxlint/src/snapshots/fixtures__overrides_env_globals_-c .oxlintrc.json .@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ working directory: fixtures/overrides_env_globals
`----

Found 5 warnings and 0 errors.
Finished in <variable>ms on 3 files with 97 rules using 1 threads.
Finished in <variable>ms on 3 files with 98 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
2 changes: 1 addition & 1 deletion ...c/snapshots/fixtures__two_rules_with_same_rule_name_-c .oxlintrc.json test.js@oxlint.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ arguments: -c .oxlintrc.json test.js
working directory: fixtures/two_rules_with_same_rule_name
----------
Found 0 warnings and 0 errors.
Finished in <variable>ms on 1 file with 61 rules using 1 threads.
Finished in <variable>ms on 1 file with 62 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
Empty file added crates/oxc_linter/fixtures/import/foo.cjs
View file
Open in desktop
Comment thread
Boshen marked this conversation as resolved.
Empty file.
Loading