Skip to content

feat(linter): promote eslint/no-eval to correctness#9231

Merged
Boshen merged 3 commits intooxc-project:mainfrom
shulaoda:refactor/eslint-no-eval
Feb 19, 2025
Merged

feat(linter): promote eslint/no-eval to correctness#9231
Boshen merged 3 commits intooxc-project:mainfrom
shulaoda:refactor/eslint-no-eval

Conversation

@shulaoda
Copy link
Contributor

closes #9188

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 19, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 19, 2025
@github-actions github-actions bot added the A-cli Area - CLI label Feb 19, 2025
@shulaoda shulaoda changed the title refactor(linter): improve eslint/no-eval refactor(linter): promote eslint/no-eval to correctness Feb 19, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 19, 2025

CodSpeed Performance Report

Merging #9231 will not alter performance

Comparing shulaoda:refactor/eslint-no-eval (6224d2d) with main (7c10ae5)

Summary

✅ 33 untouched benchmarks

@shulaoda shulaoda requested review from Boshen and Sysix February 19, 2025 14:03
@Boshen Boshen changed the title refactor(linter): promote eslint/no-eval to correctness feat(linter): promote eslint/no-eval to correctness Feb 19, 2025
@Boshen Boshen merged commit af13b1b into oxc-project:main Feb 19, 2025
25 checks passed
@github-actions github-actions bot added the C-enhancement Category - New feature or request label Feb 19, 2025
@Boshen
Copy link
Member

Boshen commented Feb 19, 2025

Awesome! Thank you so much!

@shulaoda shulaoda deleted the refactor/eslint-no-eval branch February 19, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linte: promote no-eval to correctness

2 participants